x509-cert: use the shortest name when looking attr OID #1130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
commented
Jun 29, 2023
Before this commit, the string serialization will format some attributes with the longer name when the same OID was provided by two RFC. For example this would use `STATEORPROVINCENAME` instead of `ST` for oid 2.5.4.8
baloo
force-pushed
the
baloo/x509-cert/attr-naming
branch
from
6b10caa to
848a2eb
Compare
tarcieri
approved these changes
Jun 30, 2023
baloo
added a commit
to baloo/formats
that referenced
this pull request
Jul 3, 2023
with RustCrypto#1130 there were changes in `Cargo.lock` missing after the bump of `const-oid` version.
baloo
added a commit
that referenced
this pull request
Jul 3, 2023
baloo
added a commit
to baloo/formats
that referenced
this pull request
Jul 25, 2023
Added - `add_attribute` to `RequestBuilder` ([RustCrypto#1137]) Changed - bump `serde_json` from 1.0.97 to 1.0.99 ([RustCrypto#1122]) - use the shortest name when looking attr OID ([RustCrypto#1130]) - bump `serde_json` from 1.0.100 to 1.0.103 ([RustCrypto#1158]) Fixed - RDN string representation ([RustCrypto#1126]) - `Arbitrary` for certificates ([RustCrypto#1150]) [RustCrypto#1122]: RustCrypto#1122 [RustCrypto#1126]: RustCrypto#1126 [RustCrypto#1130]: RustCrypto#1130 [RustCrypto#1137]: RustCrypto#1137 [RustCrypto#1150]: RustCrypto#1150 [RustCrypto#1158]: RustCrypto#1158
Merged
baloo
added a commit
that referenced
this pull request
Jul 25, 2023
Added - `add_attribute` to `RequestBuilder` ([#1137]) Changed - bump `serde_json` from 1.0.97 to 1.0.99 ([#1122]) - use the shortest name when looking attr OID ([#1130]) - bump `serde_json` from 1.0.100 to 1.0.103 ([#1158]) Fixed - RDN string representation ([#1126]) - `Arbitrary` for certificates ([#1150]) [#1122]: #1122 [#1126]: #1126 [#1130]: #1130 [#1137]: #1137 [#1150]: #1150 [#1158]: #1158
baloo
added a commit
to baloo/formats
that referenced
this pull request
Aug 1, 2023
This enables CI on x509-tsp. It also fixes tests that broke with RustCrypto#1130 Fixes RustCrypto#1176 Signed-off-by: Arthur Gautier <[email protected]>
Merged
baloo
added a commit
to baloo/formats
that referenced
this pull request
Aug 1, 2023
This enables CI on x509-tsp. It also fixes tests that broke with RustCrypto#1130 Fixes RustCrypto#1176 Signed-off-by: Arthur Gautier <[email protected]>
baloo
added a commit
to baloo/formats
that referenced
this pull request
Aug 1, 2023
This enables CI on x509-tsp. It also fixes tests that broke with RustCrypto#1130 Fixes RustCrypto#1176 Signed-off-by: Arthur Gautier <[email protected]>
baloo
added a commit
to baloo/formats
that referenced
this pull request
Aug 1, 2023
This enables CI on x509-tsp. It also fixes tests that broke with RustCrypto#1130 Fixes RustCrypto#1176 Signed-off-by: Arthur Gautier <[email protected]>
tarcieri
pushed a commit
that referenced
this pull request
Aug 1, 2023
This enables CI on x509-tsp. It also fixes tests that broke with #1130 Fixes #1176 Signed-off-by: Arthur Gautier <[email protected]>
scv35
pushed a commit
to scv35/format-encoders-decoders
that referenced
this pull request
Jul 4, 2025
Added - `add_attribute` to `RequestBuilder` ([#1137]) Changed - bump `serde_json` from 1.0.97 to 1.0.99 ([#1122]) - use the shortest name when looking attr OID ([#1130]) - bump `serde_json` from 1.0.100 to 1.0.103 ([#1158]) Fixed - RDN string representation ([#1126]) - `Arbitrary` for certificates ([#1150]) [#1122]: RustCrypto/formats#1122 [#1126]: RustCrypto/formats#1126 [#1130]: RustCrypto/formats#1130 [#1137]: RustCrypto/formats#1137 [#1150]: RustCrypto/formats#1150 [#1158]: RustCrypto/formats#1158
ghost-knightx56yui
added a commit
to ghost-knightx56yui/formats
that referenced
this pull request
Nov 13, 2025
Added - `add_attribute` to `RequestBuilder` ([#1137]) Changed - bump `serde_json` from 1.0.97 to 1.0.99 ([#1122]) - use the shortest name when looking attr OID ([#1130]) - bump `serde_json` from 1.0.100 to 1.0.103 ([#1158]) Fixed - RDN string representation ([#1126]) - `Arbitrary` for certificates ([#1150]) [#1122]: RustCrypto/formats#1122 [#1126]: RustCrypto/formats#1126 [#1130]: RustCrypto/formats#1130 [#1137]: RustCrypto/formats#1137 [#1150]: RustCrypto/formats#1150 [#1158]: RustCrypto/formats#1158
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, the string serialization will format some attributes with the longer name when the same OID was provided by two RFC.
For example this would use
STATEORPROVINCENAMEinstead ofSTfor oid 2.5.4.8