k256: remove ecdsa::recoverable module; add replacement docs
#675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
k256/remove-ecdsa-recoverable-module-add-docs
branch
6 times, most recently
from
e94e834 to
47d027f
Compare
Support for recovering `VerifyingKey`s from signatures has been upstreamed into the `ecdsa` crate in RustCrypto/signatures#576. This commit removes the `ecdsa::recoverable` module and the custom impls of `SigningKey`/`VerifyingKey` needed to support it. In its places are docs about how to use the generic APIs to accomplish equivalent functionality.
tarcieri
force-pushed
the
k256/remove-ecdsa-recoverable-module-add-docs
branch
from
47d027f to
6354d19
Compare
|
Just curious the plans will this be part of the 1.12 minor bump? |
Member
Author
|
Version bump of what? The new API will ship in |
Merged
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for recovering
VerifyingKeys from signatures has been upstreamed into theecdsacrate in RustCrypto/signatures#576.This commit removes the
ecdsa::recoverablemodule and the custom impls ofSigningKey/VerifyingKeyneeded to support it.In its places are docs about how to use the generic APIs to accomplish equivalent functionality.