Upgrade k256 to 0.13.1 #1800
Merged
Upgrade k256 to 0.13.1 #1800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webmaster128
approved these changes
Jul 27, 2023
Member
There was a problem hiding this comment.
In RustCrypto/signatures#392 it is explained that the values 2 and 4 are not needed for ECDSA+secp256k1 but for ECDSA+other curves. The secp256k1 specific implementation was removed:
ecdsa::recoverable module; see documentation for replacements (RustCrypto/elliptic-curves#675)
#1803 just refactors away the .unwrap() but is otherwise doing the same thing.
…_pubkey Avoid unwrapping recovery ID
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1789
The key recovery api changed a bit and seems to support RecoveryId 3 now, so I'm erroring manually in that case.