pss: make *_with_salt methods the default
#291
Closed
+69
−33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #290, this renames the following:
Pss::new=>Pss::new_unsaltedPss::new_with_salt=>Pss:newPss::new_blinded=>Pss::new_blinded_unsaltedPss::new_blinded_with_salt=>Pss::new_blindedSigningKey::new=>SigningKey::new_unsaltedSigningKey::new_with_salt_len=>SigningKey::newSigningKey::random=>SigningKey::random_unsaltedSigningKey::random_with_salt_len=>SigningKey::randomThe
*_with_saltmethods are preserved with a deprecation warning, which should help people migrate to the new versions.This also removes the
From<RsaPrivateKey>impl forSigningKey, since users should consider up front whether or not they need a salt rather than defaulting to unsalted.cc @lumag