pkcs1v15: make *_with_prefix methods the default
#290
Merged
+43
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renames the following: - `SigningKey::new` => `SigningKey::new_unprefixed` - `SigningKey::new_with_prefix` => `SigningKey::new` - `VerifyingKey::new` => `VerifyingKey::new_unprefixed` - `VerifyingKey::new_with_prefix` => `VerifyingKey::new` The `*_with_prefix` methods are preserved with a deprecation warning, which should help people migrate to the new versions. Closes #238
Member
Author
|
Per #238 having an empty prefix seems to be quite rare. People are reaching for This change might be confusing for anyone who happens to actually be using empty prefixes, though I haven't encountered anyone who is personally. |
Member
Author
|
cc @lumag |
Contributor
|
Ack, LGTM. |
tarcieri
added a commit
that referenced
this pull request
Apr 14, 2023
Similar to #290, this renames the following: - `Pss::new` => `Pss::new_unsalted` - `Pss::new_with_salt` => `Pss:new` - `Pss::new_blinded` => `Pss::new_blinded_unsalted` - `Pss::new_blinded_with_salt` => `Pss::new_blinded` - `SigningKey::new` => `SigningKey::new_unsalted` - `SigningKey::new_with_salt_len` => `SigningKey::new` - `SigningKey::random` => `SigningKey::random_unsalted` - `SigningKey::random_with_salt_len` => `SigningKey::random` The `*_with_salt` methods are preserved with a deprecation warning, which should help people migrate to the new versions. This also removes the `From<RsaPrivateKey>` impl for `SigningKey`, since users should consider up front whether or not they need a salt rather than defaulting to unsalted.
tarcieri
added a commit
that referenced
this pull request
Apr 15, 2023
Following #290, which amended `pkcs1v15::SigningKey`, this commit makes a corresponding change to `Pkcs1v15Sign` so the method name is consistent with `SigningKey::new_unprefixed`
tarcieri
added a commit
that referenced
this pull request
Apr 17, 2023
Following #290, which amended `pkcs1v15::SigningKey`, this commit makes a corresponding change to `Pkcs1v15Sign` so the method name is consistent with `SigningKey::new_unprefixed`
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames the following:
SigningKey::new=>SigningKey::new_unprefixedSigningKey::new_with_prefix=>SigningKey::newVerifyingKey::new=>VerifyingKey::new_unprefixedVerifyingKey::new_with_prefix=>VerifyingKey::newThe
*_with_prefixmethods are preserved with a deprecation warning, which should help people migrate to the new versions.Closes #238