chore(MAINTAINERS): update maintainers username#1808
Closed
kwonoj wants to merge 1 commit intoReactiveX:masterfrom
Closed
chore(MAINTAINERS): update maintainers username#1808kwonoj wants to merge 1 commit intoReactiveX:masterfrom
kwonoj wants to merge 1 commit intoReactiveX:masterfrom
Conversation
Member
|
Oops, @kwonoj, I just pushed a change to the MAINTAINERS file with the minimal required thing (just the usernames) to see if I could get it to work. That puts this out out of date. Feel free to fix it and merge it in. This isn't a change that impacts the codebase, it only impacts the CI, which we want working ASAP. So any changes you need to make, just do it and push it in. |
Member
Author
|
@Blesh it's totally ok, this PR's just amending to make LGTM works. as long as it works, this PR can be safely closed. |
Member
Author
|
Closing PR as issue's already resolved. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates
MAINTAINERSfile to include each username - per documentation (https://lgtm.co/docs/maintainers/) username is necessary to enable LGTM correctly.Note: it's kind of chicken-and-egg, LGTM might block this PR as well.
Related issue (if exists):