fix(babel): fix an issue where babel could not compile Scheduler.async#1807
Merged
kwonoj merged 1 commit intoReactiveX:masterfrom Jul 5, 2016
benlesh:fix-babel-issue
Merged
fix(babel): fix an issue where babel could not compile Scheduler.async#1807kwonoj merged 1 commit intoReactiveX:masterfrom benlesh:fix-babel-issue
Scheduler.async#1807kwonoj merged 1 commit intoReactiveX:masterfrom
benlesh:fix-babel-issue
Conversation
Member
|
LGTM |
Member
|
hmm, seems I can't make LGTM passes. :/ |
Member
Author
|
LGTM |
Member
Author
|
I'm not sure I like this LGTM stuff. |
Member
This moves the `async` property to be the last one defined, because babel will then not choke on the `,` after the property. fixes #1806
Member
Author
|
LGTM LGTM LGTM lol! |
Member
Author
|
Woot! it worked! |
Member
|
:yay: |
Member
|
@Blesh I took this PR and just merged it :) |
|
I suppose to have this problem. RxJS installed from npm and it doesn't compile with babel. How may I apply the fix? Thx. |
Member
|
@dacz unless you're directly using master via npm link or some other way, to get latest changes you may need wait next package published. I believe it'll be done quite soon, but hard to provide exactly when. |
|
ok, thanks, I'll wait. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the
asyncproperty to be the last one defined, because babel will then not choke on the,after the property.fixes #1806
related to https://phabricator.babeljs.io/T7479