Skip to content

fix: updated mocha tests to display error messages #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maribethb merged 2 commits into from
Dec 8, 2023
+2 −1
Merged

fix: updated mocha tests to display error messages #7706

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbb0ed8
fix: updated mocha tests to display error messages
btw17 Dec 8, 2023
9c3e272
fix: replaced double quotes with single quotes
btw17 Dec 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tests/mocha/webdriver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,8 @@ async function runMochaTestsInBrowser() {
console.log('There is at least one test failure, but no messages reported. Mocha may be failing because no tests are being run.');
}
for (const el of failureMessagesEls) {
console.log(await el.getText());
const messageHtml = await el.getHTML();
console.log(messageHtml.replace("<p>", "").replace("</p>", ""));

@maribethb maribethb Dec 8, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could you replace the double quotes with single quotes? it appears we don't format this file but that would match the rest of the file. Thanks!

@btw17 btw17 Dec 8, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

}
}

Expand Down