fix: updated mocha tests to display error messages#7706
Merged
maribethb merged 2 commits intoDec 8, 2023
Merged
Conversation
maribethb
approved these changes
Dec 8, 2023
maribethb
reviewed
Dec 8, 2023
| for (const el of failureMessagesEls) { | ||
| console.log(await el.getText()); | ||
| const messageHtml = await el.getHTML(); | ||
| console.log(messageHtml.replace("<p>", "").replace("</p>", "")); |
Contributor
There was a problem hiding this comment.
nit: could you replace the double quotes with single quotes? it appears we don't format this file but that would match the rest of the file. Thanks!
maribethb
approved these changes
Dec 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #7649
Proposed Changes
Instead of using
getText(), which requires a visible element, I usegetHTML()and strip out theptag.- See https://webdriver.io/docs/api/element/getText and note: only visible elements will return display.
- The root element with id
failureCounthasdisplay: none, so the text content here never displays.Previous output:
Updated output:
Reason for Changes
To resolve #7649
Test Coverage
N/A
Documentation
N/A
Additional Information
#failureCountwas previously visible, though another way to mitigate this would be to set it visible