[rocprofiler-systems] Add Fortran MPI CTests#1172
Merged
kcossett-amd merged 21 commits intoROCm:developfrom Nov 27, 2025
Merged
[rocprofiler-systems] Add Fortran MPI CTests#1172kcossett-amd merged 21 commits intoROCm:developfrom
kcossett-amd merged 21 commits intoROCm:developfrom
Conversation
kcossett-amd
force-pushed
the
users/kcossett-amd/fortran-mpi-tests
branch
from
56e8a06 to
533d42a
Compare
This was referenced Sep 30, 2025
kcossett-amd
force-pushed
the
users/kcossett-amd/fortran-mpi-tests
branch
from
f34651e to
58a8552
Compare
mradosav-amd
reviewed
Oct 3, 2025
1 task
Contributor
Author
dgaliffiAMD
approved these changes
Oct 30, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Fortran MPI test coverage by introducing a new test case using the intervals.f90 example from an external source. The implementation includes CMake configuration to detect and enable Fortran support when gfortran is available, adds the test infrastructure, and updates Docker containers to include gcc-fortran.
Key changes:
- Added Fortran MPI test case covering MPI_Init, MPI_Comm_rank, MPI_Comm_size, MPI_Send, and MPI_Recv operations
- Implemented CMake logic to conditionally enable Fortran tests based on gfortran availability
- Updated OpenSUSE Docker images to include gcc-fortran package
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| projects/rocprofiler-systems/tests/rocprof-sys-mpi-tests.cmake | Adds test configuration for Fortran MPI example with environment variables and regex validation |
| projects/rocprofiler-systems/examples/mpi/intervals_mpi.f90 | New Fortran source file implementing parallel integration using MPI |
| projects/rocprofiler-systems/examples/mpi/CMakeLists.txt | Adds gfortran detection, version checking, and Fortran MPI target configuration |
| projects/rocprofiler-systems/docker/Dockerfile.opensuse.ci | Adds gcc-fortran to CI container dependencies |
| projects/rocprofiler-systems/docker/Dockerfile.opensuse | Adds gcc-fortran to base container dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
/AzurePipelines run rocm-ci-caller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
systems-assistant bot
pushed a commit
to ROCm/rocprofiler-systems
that referenced
this pull request
Nov 27, 2025
* Add MPI CTests (use gfortran) * Add proper regex check * Skip Runtime-Instrument due to incompatibility with MPI Co-authored-by: Copilot <[email protected]> [rocm-systems] ROCm/rocm-systems#1172 (commit 63713f0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Closes 536326
Add CTests that cover Fortran MPI.
Technical Details
Uses a source code files from https://people.math.sc.edu/Burkardt/f_src/mpi/mpi.html
intervals.f90These tests cover
MPI_Comm_rank, MPI_Comm_size, MPI_Send, MPI_Recv, MPI_Initalong with their profiler variants.Uses
gfortranfor these tests. To do so, the containers were updates so that they too would installgfortran.Test Plan
Added 4 new tests.
Test Result
All tests pass.
REQUIRES #1322
Submission Checklist