MPI Fortran push-pop count fix for extra MAIN subroutine#1145
Closed
sputhala-amd wants to merge 1 commit intodevelopfrom
Closed
MPI Fortran push-pop count fix for extra MAIN subroutine#1145sputhala-amd wants to merge 1 commit intodevelopfrom
sputhala-amd wants to merge 1 commit intodevelopfrom
Conversation
Contributor
|
Are there additional Fortran tests that we should enable after your fix? |
c00995d to
64dac08
Compare
Contributor
Author
64dac08 to
6dd0031
Compare
Contributor
Author
@dgaliffiAMD , Kian has a branch with the MPI Fortran specific tests #349. I have requested Kian to test with this fix and confirm. |
Contributor
|
See #1172 for ctests (labelled |
Contributor
Author
|
This Fix is not needed as another PR fixes this issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Motivation
Fix the CI failure for MPI Fortran tests due to MAIN subroutine not getting popped from tracing
Technical Details
Fix CI assert failure by ensuring extra Fortran MAIN subroutine is popped correctly, preventing push/pop trace count mismatch.
The failure was happening when built with ROCPROFSYS_USE_MPI=ON and not with ROCPROFSYS_USE_MPI_HEADERS=ON. If the finalization call is preceded with an additional pop trace for MPI_Finalize/PMPI_Finalize then the MAIN is popped correctly for the full MPI case with ROCPROFSYS_USE_MPI=ON..
Test Plan
Manual tests were performed with the fix.
Test Result
The testing confirms the fix works.
Submission Checklist