Skip to content

Add missing third_party/printf to iree nested submodules #3953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AaronStGeorge merged 1 commit into from
Mar 16, 2026
Merged

Add missing third_party/printf to iree nested submodules #3953

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions build_tools/fetch_sources.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -434,6 +434,7 @@ def main(argv):
"third_party/benchmark",
"third_party/llvm-project",
"third_party/torch-mlir",
"third_party/printf",
Copy link
Member

@ScottTodd ScottTodd Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be going away soon: iree-org/iree#23761

Fine to include for now, but we'll just need to remove it later. WDYT?

Copy link
Contributor

@AaronStGeorge AaronStGeorge Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can pull it out on he next iree/fusilli submodule bump. I'd like to bump soon, and this change is needed, so it would be nice to get it merged.

Copy link
Member

@ScottTodd ScottTodd Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iree-org/iree#23761 was merged two hours ago. Does that change how you want to proceed here?

Copy link
Contributor

@AaronStGeorge AaronStGeorge Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's fine, bumps are manual until the build is on by default and I create an auto-bump workflow.

Currently the plan of record is to bump IREE + fusilli in TheRock to top of main fusilli and whatever IREE fusilli is using (bumped nightly to the latest IREE release) on a nightly cadence.

Copy link
Member

@ScottTodd ScottTodd Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'm fine with this either way then.

],
)
],
Expand Down
Loading