Add missing third_party/printf to iree nested submodules#3953
Add missing third_party/printf to iree nested submodules#3953AaronStGeorge merged 1 commit intoROCm:mainfrom
Conversation
The printf submodule was missing from the default nested-submodules list for iree, causing it not to be fetched. Assisted-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: zjgarvey <zjgarvey@gmail.com>
| "third_party/benchmark", | ||
| "third_party/llvm-project", | ||
| "third_party/torch-mlir", | ||
| "third_party/printf", |
There was a problem hiding this comment.
This may be going away soon: iree-org/iree#23761
Fine to include for now, but we'll just need to remove it later. WDYT?
There was a problem hiding this comment.
I can pull it out on he next iree/fusilli submodule bump. I'd like to bump soon, and this change is needed, so it would be nice to get it merged.
There was a problem hiding this comment.
iree-org/iree#23761 was merged two hours ago. Does that change how you want to proceed here?
There was a problem hiding this comment.
Yeah it's fine, bumps are manual until the build is on by default and I create an auto-bump workflow.
Currently the plan of record is to bump IREE + fusilli in TheRock to top of main fusilli and whatever IREE fusilli is using (bumped nightly to the latest IREE release) on a nightly cadence.
There was a problem hiding this comment.
Ok, I'm fine with this either way then.
3 participants
Summary
snprintf/vsnprintfcalls in the IREE runtime witheyalroz/printf, makingthird_party/printfan unconditional build dependency (printf::printfis required byiree::base).third_party/printfwas missing from the default--nested-submoduleslist forireeinfetch_sources.py, causing it not to be fetched and the IREE build to fail.🤖 Generated with Claude Code