boards/esp32: changes the approach for configurations of UART interfaces in board definitions #11294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
added
Type: cleanup
This was referenced Mar 27, 2019
Merged
Merged
Merged
gschorcht
force-pushed
the
cpu/esp32/periph/conf/uart
branch
from
496c306 to
0ce90a2
Compare
Contributor
Author
|
I have pushed required fixes after rebasing this PR onto master with merged PR #11231. Since this PR is related to PR #11231, @MrKevinWeiss might review it. |
Contributor
|
Yup I can, maybe it won't be until Monday though. |
Contributor
Author
Great, thanks. No problem. |
MrKevinWeiss
reviewed
Apr 1, 2019
Contributor
MrKevinWeiss
left a comment
MrKevinWeiss
left a comment
There was a problem hiding this comment.
Small thing, otherwise looks OK. I also tested with trying alternate uarts and with uart_mode_cfg and it works fine.
MrKevinWeiss
added
the
CI: ready for build
Contributor
Author
|
@MrKevinWeiss Thanks for reviewing and testing it. |
gschorcht
force-pushed
the
cpu/esp32/periph/conf/uart
branch
from
0ce90a2 to
acb5493
Compare
UART devices are now configured using static array in header files instead of static variables in implementation to be able to define UART_NUMOF using the size of the array instead of a variable.
UART devices are now configured using static array in header files instead of static variables in implementation to be able to define UART_NUMOF using the size of the array instead of a variable.
gschorcht
force-pushed
the
cpu/esp32/periph/conf/uart
branch
from
acb5493 to
3cb08e9
Compare
Contributor
Author
|
@MrKevinWeiss Rebased after PR # 11289 has been merged. Should be ready now to be merged. |
Contributor
|
OK, I will retest tomorrow morning! |
MrKevinWeiss
approved these changes
May 9, 2019
Contributor
MrKevinWeiss
left a comment
MrKevinWeiss
left a comment
There was a problem hiding this comment.
Quick retest, looks good. ACK!
MrKevinWeiss
added
CI: ready for build
Contributor
Author
|
@MrKevinWeiss Thanks a lot for testing and reviewing it again 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR changes the approach of peripheral configurations for UART interfaces in board definitions to the usual RIOT approach. With these changes, peripheral configurations use static const arrays in the
boards/esp32*/periph_conf.hfiles and define the*_NUMOFmacros using the size of these static array.The static configuration arrays contain only definitions that can be changed by the board definition or the application. They do not contain any MCU implementation detail. The board definitions use preprocessor defines as before to fill these static configuration arrays. This makes it possible to override all configurations either with the make command or application specific configuration files.
Please note that commit 8b48dfd is in also in related PRs to get each PR compilable separately.
Testing procedure
Compilation and test with the most common ESP32 board should be executed
Issues/PRs references
PRs #11289 #11290 #11291 #11292 #11293 #11294 are releated and should be merged together.