boards/esp32: changes the approach for configurations of DAC channels in board definitions #11290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
added
Type: cleanup
This was referenced Mar 27, 2019
boards/esp32: changes the approach for configurations of UART interfaces in board definitions
#11294
Merged
Merged
Merged
leandrolanzieri
added
Reviewed: 1-fundamentals
Contributor
|
Tested on esp32-wroom-32 and works fine. I would still move the esp32-olimex-evb change to a different commit as it actually is not so related to the change of the way it is configured. |
Contributor
Author
|
@leandrolanzieri I reverted the commit with |
leandrolanzieri
added
CI: ready for build
Contributor
|
@gschorcht please squash |
leandrolanzieri
added
the
State: waiting for other PR
gschorcht
force-pushed
the
cpu/esp32/periph/conf/dac
branch
from
43bec86 to
bd64629
Compare
Contributor
Author
|
@leandrolanzieri Thanks for reviewing and testing. Squashed. |
leandrolanzieri
added
the
CI: ready for build
gschorcht
force-pushed
the
cpu/esp32/periph/conf/dac
branch
from
bd64629 to
372f97c
Compare
gschorcht
added
CI: ready for build
gschorcht
force-pushed
the
cpu/esp32/periph/conf/dac
branch
from
98053e1 to
7e52c57
Compare
Contributor
I meant rebase >:( |
Contributor
Author
|
@leandrolanzieri All PRs are rebased. I'm not sure about the order in which we should merge them. All PRs are compilable and are working separatly. However, all of them require the changes in commit 8ede5be and include this commit therefore. Therefore, I would suggest to start with PR #11289. After that, I will rebase all of them again. |
DAC pins are now configured using static arrays in header files instead of static variables in implementation to be able to define DAC_NUMOF using the size of these arrays instead of a variable.
DAC pins are now configured using static arrays in header files instead of static variables in implementation to be able to define DAC_NUMOF using the size of these arrays instead of a variable.
gschorcht
force-pushed
the
cpu/esp32/periph/conf/dac
branch
from
7e52c57 to
7e8a1c1
Compare
Contributor
Author
|
@leandrolanzieri I rebased PRs #11290 to #11294. |
Contributor
Author
|
@leandrolanzieri Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR changes the approach of peripheral configurations for DAC channels in board definitions to the usual RIOT approach. With these changes, peripheral configurations use static const arrays in the
boards/esp32*/periph_conf.hfiles and define the*_NUMOFmacros using the size of these static array.The static configuration arrays contain only definitions that can be changed by the board definition or the application. They do not contain any MCU implementation detail. The board definitions use preprocessor defines as before to fill these static configuration arrays. This makes it possible to override all configurations either with the make command or application specific configuration files.
Please note that commit 8b48dfd is in also in related PRs to get each PR compilable separately.
Testing procedure
Compilation and test with the most common ESP32 board should be executed
Issues/PRs references
PRs #11289 #11290 #11291 #11292 #11293 #11294 are releated and should be merged together.
Depends on PR #11289.