Fix bucketd and stormd integration#202
Merged
dr-orlovsky merged 1 commit intoRGB-WG:masterfrom Sep 28, 2022
Merged
Conversation
oacdutra
changed the title
dr-orlovsky
reviewed
Sep 18, 2022
Member
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
Seems correct, thank you for figuring this out. However why do you change the sending daemon id? (See the review comment). Isn't it not working with the real id? If not, than that is a another bug.
oacdutra
force-pushed
the
fix/bucket-storm-integration
branch
from
19b1c2c to
64fbd4e
Compare
oacdutra
force-pushed
the
fix/bucket-storm-integration
branch
from
7f835d6 to
1eb386c
Compare
Member
Author
|
Hi @dr-orlovsky, I followed your recommendations and solved this issue with another approach. I changed the message sent to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After running
rgb-cli finalizewith --send parameter, an error occurs ("ESB request processing error: ESB error: provided service bus id STORM is unknown").This error occurs because the storm bus configuration is not passed to bucketd daemon and incorrect strict enconding service ids.
This PR fixies this.