Docs improviments (Storm integration)#12
Merged
dr-orlovsky merged 1 commit intoLNP-BP:masterfrom Dec 27, 2022
oacdutra:feat/rgb-storm-integration
Merged
Docs improviments (Storm integration)#12dr-orlovsky merged 1 commit intoLNP-BP:masterfrom oacdutra:feat/rgb-storm-integration
dr-orlovsky merged 1 commit intoLNP-BP:masterfrom
oacdutra:feat/rgb-storm-integration
Conversation
dr-orlovsky
reviewed
Sep 18, 2022
Member
dr-orlovsky
left a comment
dr-orlovsky
left a comment
There was a problem hiding this comment.
- Do we need to get all PRs listed in the description to be merged before merging this one?
- Pls check my review comment
Comment on lines
+148
to
+150
| NODE_ID="..." #The node_id of the beneficiary LN node | ||
| STORM_ADDR="..." #The stormd IP connected in your RGB node | ||
| STORM_PORT="..." #The stormd RPC port |
Member
There was a problem hiding this comment.
Are these used anywhere? If yes, I think ppl will struggle to repeat the demo in this way; we first need to add *-cli commands which would return the node ids, and than put here stuff like *_ID=`*-cli node-id`
Member
Author
There was a problem hiding this comment.
Good point!
I will make the changes.
Member
Author
Yes, I could transfer the consignment file only with all the fixes.
Sure. |
dr-orlovsky
approved these changes
Dec 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After making tests and fixies the integration between
rgb-nodeandstorm-node, I decided to add information about storm integration works.Related Issues