Conversation
|
Here's the corrected link for "various hackery" |
|
Resolves #320 |
|
wowie! yay! thanks! this will be cool, il be able to show off my minecraft stuff! |
ashquarky
force-pushed
the
work/shot-final-stretch
branch
from
e95881d to
d75c38a
Compare
mrjvs
left a comment
mrjvs
left a comment
There was a problem hiding this comment.
I can't test properly, but it looks good in browser.
Couple comments, nothing major
| padding: 5px; | ||
| #shot-preview { | ||
| float: right; | ||
| width: 200px; /* to do */ |
There was a problem hiding this comment.
Honestly can't remember what this was. probably maintaining aspect-ratio (later solved with background-size: contain)
| <div id="shot-preview" data-shot-preview="1"></div> | ||
|
|
||
| <div className="shot-picker"> | ||
| <input type="radio" name="shot-type" className="shot top" data-shot="1" data-lls="shot-top"></input> | ||
| <input type="radio" name="shot-type" className="shot btm" data-shot="0" data-lls="shot-btm"></input> | ||
| <div id="shot-clear"> | ||
| <div className="sprite sp-clear centred"></div> | ||
| <input type="radio" name="shot-type" data-shot-clear="1"></input> | ||
| </div> | ||
| </div> | ||
|
|
||
| <input type="file" name="shot" data-shot-upload="1" disabled></input> |
There was a problem hiding this comment.
I've seen you type out <tag></tag> multiple times. Just wanna remind you that you can selfclose them like this: <tag/>.
Mostly preference though, just wanted to say it just incase you don't know about it.
There was a problem hiding this comment.
I do, VSCode just defaults to the syntax
There was a problem hiding this comment.
Maybe we can have an ESLint rule for this?
4 participants
Resolves #XXX
Changes:
classListpolyfill everywhere and remove old implRelease announcement absolutely must credit @760ceb3b9c0ba4872cadf3ce35a7a494 and @Enderspearl184, whose research into LLS and the applet made this possible at all. Their info is the only reason we know how uploading works.
Depends on #403 - draft until that lands.