Conversation
Add GRPC server for internal communication
Minification today, bundling tomorrow!
Will need to deal with PJAX uhhhh later
I'm starting to get unsure how this is supposed to work at all
More readable
Added dev:build since the original code skips "tsc" which is faster
Since we have a bundler, might as well use it! Apparently previous work was (accidentally) using CJS format, which doesn't work on browser. Changing to IIFE means we don't get global scope anymore; which is needed for various places in the Juxt codebase where onclick= etc. are used. Eventually need to move to addEventListener, but for now explicitly export things by setting them on window. This allows us to stop vendoring PJAX and actually bundle it properly. Nice!
Since we no longer rely on the global scope for onclick=, re-enable full minification!
web: Pack client JS and add hamburger menu to web frontend
fix(web): update post perms check to match api server
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this release: