Skip to content

Chore: cleanup posting logic#129

Merged
mrjvs merged 2 commits intodevfrom
chore/cleanup-post-logic
Jun 11, 2025
Merged

Chore: cleanup posting logic#129
mrjvs merged 2 commits intodevfrom
chore/cleanup-post-logic

Conversation

@mrjvs
Copy link
Contributor

@mrjvs mrjvs commented Jun 9, 2025

changes:

  • Cleanup posting logic

There was a TODO to clean up the logic, so here it is!
The original logic did have a few bugs, biggest one being that access_level field doesn't exist.

@ashquarky can you go through and run some tests, make sure all the checks are correct?
@CaramelKat it would also be nice if you'd take a look at it, extra pair of eyes is always good.

@mrjvs mrjvs requested review from CaramelKat and ashquarky June 9, 2025 12:40
Copy link
Member

@CaramelKat CaramelKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell this is pretty solid. Trying it locally with a couple options seemed to be fine, but I've not hit every edge case (another point to us having automated tests lol). I'd like to get Luca's opinion as well just to be sure but I think we're good 👍

@ashquarky
Copy link
Member

Looks like a developer account can't post to announcements with this setup (it passes the access level requirement, but fails on isPulicPostableCommunity).
I am. actually unsure what the intended behaviour is here? I have posted to announcements with my dev acccount before.

@mrjvs mrjvs merged commit 8743dd4 into dev Jun 11, 2025
16 of 17 checks passed
@mrjvs mrjvs deleted the chore/cleanup-post-logic branch June 11, 2025 10:06
@mrjvs mrjvs mentioned this pull request Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants