Conversation
CaramelKat
approved these changes
Jun 9, 2025
Member
CaramelKat
left a comment
There was a problem hiding this comment.
As far as I can tell this is pretty solid. Trying it locally with a couple options seemed to be fine, but I've not hit every edge case (another point to us having automated tests lol). I'd like to get Luca's opinion as well just to be sure but I think we're good 👍
Member
|
Looks like a developer account can't post to announcements with this setup (it passes the access level requirement, but fails on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes:
There was a TODO to clean up the logic, so here it is!
The original logic did have a few bugs, biggest one being that
access_levelfield doesn't exist.@ashquarky can you go through and run some tests, make sure all the checks are correct?
@CaramelKat it would also be nice if you'd take a look at it, extra pair of eyes is always good.