Fix default gateway in static IP config to match VH-109 DHCP config

[rzblue]

Description

Closes #2362
The default gateway handed out by the vh-109 dhcp server is .4, not .1.
prompted by https://www.chiefdelphi.com/t/photonvision-not-accessible-over-vh109-running-ap-firmware/514418/29

Meta

Merge checklist:

• Pull Request title is short, imperative summary of proposed changes
• The description documents the what and why, including events that led to this PR
• If this PR changes behavior or adds a feature, user documentation is updated
• If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
• If this PR touches configuration, this is backwards compatible with all settings going back to the previous seasons's last release (seasons end after champs ends)
• If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
• If this PR addresses a bug, a regression test for it is added (does this change need a regression test...?)

[crschardt]

Does the gateway being set to .4 actually have any impact?

This will work for on robot network with the new radio, but will it cause problems with static IP on the old radio or non-robot networks?

[rzblue]

Does the gateway being set to .4 actually have any impact?

yes, in the case where a team is using the vh-113 practice field firmware and accessing the coprocessor from another subnet as in the linked CD thread.

This will work for on robot network with the new radio, but will it cause problems with static IP on the old radio

No, because the OM5P radio at .1 will not do routing anyway.

or non-robot networks?

It won't change this behavior except in the case where both a) a user is accessing the coprocessor from another subnet and b) they have a router at the .1 IP address.

[crschardt]

What about the edge case of a coprocessor on a home network with a static IP set? Can I use apt from the coprocessor to install a program on it if the network gateway is .1?

[rzblue]

In that case, yes, this would break that. If that (static IP with internet access on a home network) is a configuration PhotonVision wants to support, a default gateway setting should be exposed, because not all home networks use .1 as the default gateway (many use .254).

I personally don't think that's something that should be in scope for PhotonVision- if you want internet access, either use a DHCP address, or configure the static IP with the correct gateway manually outside of PV.

[mcm001]

I think that I'm happy with this:

• right now, .4 is objectively less wrong that .1
• this MR only changes static configs. DHCP remains the same
• we do definitely need to talk about this more comprehensively. But that’s separate to this MR

Thanks, Ryan!

[samfreund]

Alr, guy on CD says it works. Merging

[dcunited001]

Thanks 👍