Skip to content

Use WPILib Artifactory mirror instead of Maven Central#2277

Merged
Gold856 merged 3 commits intoPhotonVision:mainfrom
mcm001:mmorley/wpilib-ex-maven
Jan 5, 2026
Merged

Use WPILib Artifactory mirror instead of Maven Central#2277
Gold856 merged 3 commits intoPhotonVision:mainfrom
mcm001:mmorley/wpilib-ex-maven

Conversation

@mcm001
Copy link
Contributor

@mcm001 mcm001 commented Jan 5, 2026

Description

By hitting WPIlib's Artifactory Maven Central mirror instead of Maven Central, we should reduce the number of 403 flakes we see during workflow runs. This also removes jogamp from the repository list, as jogamp dependencies were removed in #1926.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@mcm001 mcm001 marked this pull request as ready for review January 5, 2026 01:15
@mcm001 mcm001 requested review from a team as code owners January 5, 2026 01:15
@Gold856
Copy link
Member

Gold856 commented Jan 5, 2026

For redundancy, can we have both? I'd prefer to hit Maven Central first, then fall back to Artifactory if needed.

@mcm001
Copy link
Contributor Author

mcm001 commented Jan 5, 2026

We can have both. Should we prefer to hit wpilib's infrastructure instead of Maven central's?

@Gold856
Copy link
Member

Gold856 commented Jan 5, 2026

It doesn't particularly matter I think. May as well try and hit Maven Central less.

@Gold856 Gold856 changed the title Use wpilib artifactory instead of mavencentral Use WPILib Artifactory mirror instead of Maven Central Jan 5, 2026
@Gold856 Gold856 merged commit a2b06bd into PhotonVision:main Jan 5, 2026
53 checks passed
@mcm001 mcm001 deleted the mmorley/wpilib-ex-maven branch January 5, 2026 03:27
@Gold856
Copy link
Member

Gold856 commented Jan 5, 2026

For posterity, this does leave Maven Central in as an alternate repository, but Gradle will hit WPILib's Artifactory first. Maven Central is now just a fallback.

@rzblue
Copy link
Contributor

rzblue commented Jan 5, 2026

Late, but if you hit maven central first it won't get cached in WPILib's Artifactory. Hitting Artifactory first is fine and will really only fail if it's not already cached and maven central is down/denies Artifactory's request.

@samfreund
Copy link
Member

Late, but if you hit maven central first it won't get cached in WPILib's Artifactory. Hitting Artifactory first is fine and will really only fail if it's not already cached and maven central is down/denies Artifactory's request.

My understanding is that the hits go in the order that they're listed, so if we list the WPILib artifactory first we should hit that prior to Maven Central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants