Merged
Conversation
mcm001
approved these changes
Apr 20, 2025
samfreund
pushed a commit
to samfreund/photonvision
that referenced
this pull request
Jun 28, 2025
7 tasks
Gold856
pushed a commit
that referenced
this pull request
Jan 5, 2026
## Description By hitting WPIlib's Artifactory Maven Central mirror instead of Maven Central, we should reduce the number of 403 flakes we see during workflow runs. This also removes jogamp from the repository list, as jogamp dependencies were removed in #1926. ## Meta Merge checklist: - [x] Pull Request title is [short, imperative summary](https://cbea.ms/git-commit/) of proposed changes - [x] The description documents the _what_ and _why_ - [ ] If this PR changes behavior or adds a feature, user documentation is updated - [ ] If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly - [ ] If this PR touches configuration, this is backwards compatible with settings back to v2025.3.2 - [ ] If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated - [ ] If this PR addresses a bug, a regression test for it is added --------- Co-authored-by: samfreund <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed that some of our Gradle files had some unnecessary code, so I decided to do some housekeeping and remove them.
There's a bunch of version checks in the Javadoc task that simply isn't necessary anymore because we've moved to Java 17. Java 17 also allows us to change
Xwerrorargument intoWerror. Next, there was anothergenerateJavaDocstask that was in a Gradle file included by photon-core and photon-server. We no longer generate Javadoc for either, nor do we want to, so it's been removed. There was also acreateAllCombinedtask that created an artifact with an-allclassifier. It is unused, so it has been removed.Finally, the jogamp dependency has been removed, as it is no longer needed after
GPUAcceleratedHSVPipewas removed in #1830.Meta
Merge checklist: