Skip to content

Use deploy-utils instead of an external ssh plugin#2077

Merged
samfreund merged 2 commits intoPhotonVision:mainfrom
Gold856:use-deploy-utils
Aug 22, 2025
Merged

Use deploy-utils instead of an external ssh plugin#2077
samfreund merged 2 commits intoPhotonVision:mainfrom
Gold856:use-deploy-utils

Conversation

@Gold856
Copy link
Member

@Gold856 Gold856 commented Aug 19, 2025

Description

deploy-utils is bundled as part of GradleRIO, so we may as well use it instead of using an external ssh plugin.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested a review from a team as a code owner August 19, 2025 03:17
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Aug 19, 2025
spacey-sooty
spacey-sooty previously approved these changes Aug 19, 2025
Copy link
Member

@spacey-sooty spacey-sooty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice happy to see this. All looks reasonable if CI passes

@github-actions github-actions bot added documentation Anything relating to https://docs.photonvision.org and removed backend Things relating to photon-core and photon-server labels Aug 19, 2025
@github-actions github-actions bot added the backend Things relating to photon-core and photon-server label Aug 19, 2025
@samfreund
Copy link
Member

I'll test tonight. Also consider adding support for a custom password/username.

@Gold856 Gold856 force-pushed the use-deploy-utils branch 2 times, most recently from 368fbf0 to 9546abb Compare August 22, 2025 05:20
Copy link
Member

@samfreund samfreund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the new gradle arguments to the README?

Add pw and usr properties to readme
@samfreund samfreund enabled auto-merge (squash) August 22, 2025 05:46
@samfreund samfreund merged commit fcbc392 into PhotonVision:main Aug 22, 2025
42 checks passed
@Gold856 Gold856 deleted the use-deploy-utils branch August 22, 2025 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend Things relating to photon-core and photon-server documentation Anything relating to https://docs.photonvision.org

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants