Use deploy-utils instead of an external ssh plugin#2077
Merged
samfreund merged 2 commits intoPhotonVision:mainfrom Aug 22, 2025
Merged
Use deploy-utils instead of an external ssh plugin#2077samfreund merged 2 commits intoPhotonVision:mainfrom
samfreund merged 2 commits intoPhotonVision:mainfrom
Conversation
spacey-sooty
previously approved these changes
Aug 19, 2025
Member
spacey-sooty
left a comment
There was a problem hiding this comment.
Nice happy to see this. All looks reasonable if CI passes
a2aa5d5 to
3918f5f
Compare
3918f5f to
8f29eea
Compare
Member
|
I'll test tonight. Also consider adding support for a custom password/username. |
8acc353 to
698623e
Compare
samfreund
reviewed
Aug 22, 2025
368fbf0 to
9546abb
Compare
samfreund
approved these changes
Aug 22, 2025
samfreund
requested changes
Aug 22, 2025
Member
samfreund
left a comment
There was a problem hiding this comment.
Can we add the new gradle arguments to the README?
Add pw and usr properties to readme
9546abb to
ad3a492
Compare
samfreund
approved these changes
Aug 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
deploy-utils is bundled as part of GradleRIO, so we may as well use it instead of using an external ssh plugin.
Meta
Merge checklist: