Move metrics subtable to root PV table#2007
Merged
samfreund merged 1 commit intoPhotonVision:mainfrom Jul 22, 2025
Merged
Conversation
aa1efad to
9ab92c8
Compare
9ab92c8 to
0ba56c6
Compare
mcm001
reviewed
Jul 22, 2025
photon-core/src/main/java/org/photonvision/common/hardware/metrics/MetricsManager.java
Show resolved
Hide resolved
mcm001
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The metrics subtable is now published under the main PV table, as publishing it under the coproc table means that it's viewed as another MAC address, which it isn't.
Additionally adds a note that the coproc table is meant for MAC address stuff only.
Meta
Merge checklist: