Fix camera setup modal not closing and navigation not working#1979
Merged
samfreund merged 1 commit intoPhotonVision:mainfrom Jun 29, 2025
Merged
Conversation
c533390 to
e85cf24
Compare
Member
Author
|
I should also note this fixed the Camera Matching tab text being completely static. It now pulsates in red when cameras need configuring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#1978 fixed the modal not working, but the modal could not be closed, and navigation to the Camera Matching tab didn't work either. This is because
v-modelattempted to write to the read-onlyneedsCamerasConfiguredcomputed property, and since it couldn't be set to false, the modal stayed up. This has been changed so that a separaterefis used to track the state of the modal, which is more consistent with how other modals are set up. Navigation to the Camera Matching tab has also been fixed by using<router-link>. Finally, thewarningShownandneedsCamerasConfiguredproperties have been deduplicated and moved to the camera settings store, motivated by the fact that there's a typo in the photon-sidebar version (PlaceHolder instead of Placeholder).Meta
Merge checklist: