Skip to content

Clarify and fix OpenCV/WPILib version checking error #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gold856 merged 3 commits into from
Jul 12, 2025
+42 −14
Merged

Clarify and fix OpenCV/WPILib version checking error #1963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5749d87
Fix opencv version checking error
spacey-sooty May 15, 2025
179bac1
add missing newline
spacey-sooty May 15, 2025
a4b6d67
Update message
Gold856 Jul 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 22 additions & 8 deletions photon-lib/src/main/java/org/photonvision/PhotonCamera.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,11 +195,18 @@ public static void verifyDependencies() {
+ ">>> but you are using WPILib "
+ WPILibVersion.Version
+ """
>>> \s
\n>>> \s
>>> This is neither tested nor supported. \s
>>> You MUST update PhotonVision, \s
>>> PhotonLib, or both. \s
>>> Verify the output of `./gradlew dependencies`
>>> You MUST update WPILib, PhotonLib, or both.
>>> Check `./gradlew dependencies` and ensure\s
>>> all mentions of OpenCV match the version \s
>>> that PhotonLib was built for. If you find a
>>> a mismatched version in a dependency, you\s
>>> must take steps to update the version of \s
>>> OpenCV used in that dependency. If you do\s
>>> not control that dependency and an updated\s
>>> version is not available, contact the \s
>>> developers of that dependency. \s
>>> \s
>>> Your code will now crash. \s
>>> We hope your day gets better. \s
Expand Down Expand Up @@ -232,11 +239,18 @@ public static void verifyDependencies() {
+ ">>> but you are using OpenCV "
+ Core.VERSION
+ """
>>> \s
\n>>> \s
>>> This is neither tested nor supported. \s
>>> You MUST update PhotonVision, \s
>>> PhotonLib, or both. \s
>>> Verify the output of `./gradlew dependencies`
>>> You MUST update WPILib, PhotonLib, or both.
>>> Check `./gradlew dependencies` and ensure\s
>>> all mentions of OpenCV match the version \s
>>> that PhotonLib was built for. If you find a
>>> a mismatched version in a dependency, you\s
>>> must take steps to update the version of \s
>>> OpenCV used in that dependency. If you do\s
>>> not control that dependency and an updated\s
>>> version is not available, contact the \s
>>> developers of that dependency. \s
>>> \s
>>> Your code will now crash. \s
>>> We hope your day gets better. \s
Expand Down
26 changes: 20 additions & 6 deletions photon-lib/src/main/native/cpp/photon/PhotonCamera.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,16 @@ inline void verifyDependencies() {
bfw +=
"\n>>> \n"
">>> This is neither tested nor supported. \n"
">>> You MUST update PhotonVision, \n"
">>> PhotonLib, or both. \n"
">>> Verify the output of `./gradlew dependencies` \n"
">>> You MUST update WPILib, PhotonLib, or both.\n"
">>> Check `./gradlew dependencies` and ensure\n"
">>> all mentions of WPILib match the version \n"
">>> that PhotonLib was built for. If you find a"
">>> a mismatched version in a dependency, you\n"
">>> must take steps to update the version of \n"
">>> WPILib used in that dependency. If you do\n"
">>> not control that dependency and an updated\n"
">>> version is not available, contact the \n"
">>> developers of that dependency. \n"
">>> \n"
">>> Your code will now crash. \n"
">>> We hope your day gets better. \n"
Expand Down Expand Up @@ -104,9 +111,16 @@ inline void verifyDependencies() {
bfw +=
"\n>>> \n"
">>> This is neither tested nor supported. \n"
">>> You MUST update PhotonVision, \n"
">>> PhotonLib, or both. \n"
">>> Verify the output of `./gradlew dependencies` \n"
">>> You MUST update WPILib, PhotonLib, or both.\n"
">>> Check `./gradlew dependencies` and ensure\n"
">>> all mentions of OpenCV match the version \n"
">>> that PhotonLib was built for. If you find a"
">>> a mismatched version in a dependency, you\n"
">>> must take steps to update the version of \n"
">>> OpenCV used in that dependency. If you do\n"
">>> not control that dependency and an updated\n"
">>> version is not available, contact the \n"
">>> developers of that dependency. \n"
">>> \n"
">>> Your code will now crash. \n"
">>> We hope your day gets better. \n"
Expand Down
Loading