Clarify and fix OpenCV/WPILib version checking error#1963
Clarify and fix OpenCV/WPILib version checking error#1963Gold856 merged 3 commits intoPhotonVision:mainfrom
Conversation
|
The comment on chief Delphi also had a missing return character. Could you add that here? |
|
The other failure mode is a vendor dependency, pulling in something stupid. Should we mention that? |
|
Perhaps something about how the versions need to match, not just about they need to be upgraded? |
Something like |
I wouldn't bother unless you can think of a vendor which does, it would only lead people down the wrong path right now.
Versions needing to match is difficult, we often have mismatching versions. If they are both latest it should work. |
|
There should be an explanation on the |
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
Signed-off-by: Jade Turner <spacey-sooty@proton.me>
1e68189 to
179bac1
Compare
|
WPILib version message also needs to be updated 💀 |
213bab0 to
a4b6d67
Compare
Description
Fixed the error in the OpenCV/WPILib version checking crash and clarified it, since it's not PhotonVision that needs updating, but rather WPILib.
Reported on chief https://www.chiefdelphi.com/t/opencv-is-version-4-6-0-and-needs-to-be-4-10-0/501751/7
Meta
Merge checklist: