Skip to content

Verify that nmcli installed #1929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gold856 merged 4 commits into from
Aug 10, 2025
Merged

Verify that nmcli installed #1929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1994711
Verify that nmcli installed
mcm001 Apr 22, 2025
ef78aeb
Merge branch 'main' into assert-nmcli-present
crschardt Aug 9, 2025
72a99f4
spotless
crschardt Aug 9, 2025
34aa42a
this should be private
crschardt Aug 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions photon-core/src/main/java/org/photonvision/common/networking/NetworkManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ public void initialize(boolean shouldManage) {
return;
}

if (!NetworkUtils.nmcliIsInstalled()) {
logger.error("Cannot manage network without nmcli!");
this.networkingIsDisabled = true;
return;
}

// Start tasks to monitor the network interface(s)
var ethernetDevices = NetworkUtils.getAllWiredInterfaces();
for (NMDeviceInfo deviceInfo : ethernetDevices) {
Expand Down
12 changes: 12 additions & 0 deletions photon-core/src/main/java/org/photonvision/common/networking/NetworkUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,18 @@ public NMDeviceInfo(String c, String d, String type) {
}
}

public static boolean nmcliIsInstalled() {
var shell = new ShellExec(true, false);
try {
shell.executeBashCommand("nmcli --version");

return shell.getExitCode() == 0;
} catch (IOException e) {
logger.error("Could not query nmcli version", e);
return false;
}
}

private static List<NMDeviceInfo> allInterfaces = new ArrayList<>();
private static long lastReadTimestamp = 0;

Expand Down
Loading