Verify that nmcli installed#1929
Merged
Gold856 merged 4 commits intoPhotonVision:mainfrom Aug 10, 2025
Merged
Conversation
github-actions
bot
added
the
backend
crschardt
reviewed
Aug 9, 2025
photon-core/src/main/java/org/photonvision/common/networking/NetworkManager.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously, NetworkManager would happily go asking for networkmanager to do things even if it wasn't installed. This should never be the case, but we should bail out early if it is regardless IMO. This prevents logs and the UI from looking suspiciously "working", if you ignore the exit code. Up for debate if we actually need this feature.
Meta
Merge checklist: