Skip to content

Clean up .gitignore#1897

Merged
mcm001 merged 1 commit intoPhotonVision:mainfrom
Gold856:clean-up-gitignore
Apr 15, 2025
Merged

Clean up .gitignore#1897
mcm001 merged 1 commit intoPhotonVision:mainfrom
Gold856:clean-up-gitignore

Conversation

@Gold856
Copy link
Member

@Gold856 Gold856 commented Apr 14, 2025

Description

We have many .gitignores spread out across the different subprojects. However, there seems to be either a lot of redundant or unnecessary files ignored. It's really confusing to figure out what's ignored and where it's being ignored from, so the .gitignore files have been consolidated into the root .gitignore, with some modifications made when necessary.

Meta

Merge checklist:

  • Pull Request title is short, imperative summary of proposed changes
  • The description documents the what and why
  • If this PR changes behavior or adds a feature, user documentation is updated
  • If this PR touches photon-serde, all messages have been regenerated and hashes have not changed unexpectedly
  • If this PR touches configuration, this is backwards compatible with settings back to v2024.3.1
  • If this PR touches pipeline settings or anything related to data exchange, the frontend typing is updated
  • If this PR addresses a bug, a regression test for it is added

@Gold856 Gold856 requested review from a team as code owners April 14, 2025 23:14
@Gold856 Gold856 force-pushed the clean-up-gitignore branch from 149093b to 7113636 Compare April 14, 2025 23:38
@Gold856 Gold856 force-pushed the clean-up-gitignore branch from 7113636 to 67f66cd Compare April 15, 2025 00:36
@samfreund
Copy link
Member

Why are there a bunch of formatting changes?

@Gold856
Copy link
Member Author

Gold856 commented Apr 15, 2025

Some of the files fell under the previous .gitignore. I believe that stopped wpiformat from correctly adding the license header. This is what they're supposed to look like.

@samfreund
Copy link
Member

Some of the files fell under the previous .gitignore. I believe that stopped wpiformat from correctly adding the license header. This is what they're supposed to look like.

So they were in the repo, then they got added to the gitignore? Just trying to figure out the timeline here.

@Gold856
Copy link
Member Author

Gold856 commented Apr 15, 2025

Something like that? I'm honestly not going to question it too much.

@mcm001 mcm001 merged commit 63b1ff2 into PhotonVision:main Apr 15, 2025
39 checks passed
@Gold856 Gold856 deleted the clean-up-gitignore branch April 15, 2025 02:37
samfreund pushed a commit to samfreund/photonvision that referenced this pull request Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants