Skip to content

photonlibpy: License under MIT#1700

Merged
mcm001 merged 1 commit intoPhotonVision:mainfrom
auscompgeek:py-licence
Jan 13, 2025
Merged

photonlibpy: License under MIT#1700
mcm001 merged 1 commit intoPhotonVision:mainfrom
auscompgeek:py-licence

Conversation

@auscompgeek
Copy link
Contributor

@auscompgeek auscompgeek commented Jan 11, 2025

Everything under the photon-lib directory is intended to all be licensed under MIT:

Presumably we don't want to force teams to release their robot code under GPL.

@auscompgeek auscompgeek requested a review from a team as a code owner January 11, 2025 06:13
@auscompgeek
Copy link
Contributor Author

Gah, I just saw the serde generated files also have a GPL header. Please hold...

@auscompgeek auscompgeek marked this pull request as draft January 11, 2025 11:32
@auscompgeek auscompgeek marked this pull request as ready for review January 12, 2025 01:06
@auscompgeek
Copy link
Contributor Author

👋 @LucienMorey @james-ward @mcm001 @crschardt @spacey-sooty @gerth2 @JochemvdBroek y'all have commits touching the non-generated files in photonlibpy since #1408.

The licensing of photon-lib is a little bit confused right now; there's a LICENSE file at photon-lib/LICENSE which implies the contents of that subdirectory should all be MIT:

However, due to a historical accident #1408 added a GPL header to photonlibpy/__init__.py. The intention seems to have always been that this should be MIT licensed, since this is intended for robot code (see #1704 for more context).

If you're all okay with this change, please leave a comment explicitly agreeing to release your changes under the MIT licence.

For clarity, I agree for my changes to be licensed under MIT.

> git shortlog -n -s 9e6a066561773d1fc66694cd8f4f6c94f5d6755c.. photonlibpy/*.py photonlibpy/{estimation,networktables,simulation,targeting,timesync}/
    12  Lucien Morey
     4  James Ward
     3  Matt
     2  Craig Schardt
     2  David Vo
     2  Jade
     1  Chris Gerth
     1  Jochem

@mcm001
Copy link
Contributor

mcm001 commented Jan 12, 2025

Yes, the intent was to license photon-lib under MIT. And yes agreed that's good with me.

Photon-targeting was added later and linked into -lib without conversation about licensing implications. We still need to hammer that out separately.

@spacey-sooty
Copy link
Member

I am happy with my changes being relicensed under MIT

@LucienMorey
Copy link
Contributor

I agree

@JochemvdBroek
Copy link
Contributor

JochemvdBroek commented Jan 12, 2025

I also agree with releasing my changes under the MIT licence

@james-ward
Copy link
Contributor

MIT is fine by me.

@gerth2
Copy link
Contributor

gerth2 commented Jan 12, 2025

I agree

@crschardt
Copy link
Contributor

I agree for my changes to be licensed under MIT.

@mcm001 mcm001 merged commit a08dc37 into PhotonVision:main Jan 13, 2025
mcm001 pushed a commit to mcm001/photonvision that referenced this pull request Feb 18, 2025
Everything under the `photon-lib` directory is intended to all be
licensed under MIT:


https://github.com/PhotonVision/photonvision/blob/e40c8fbca08e8397e00e35f72809ac69d752ad57/photon-lib/.styleguide-license#L2

Presumably we don't want to force teams to release their robot code
under GPL.
@Gold856 Gold856 added the photonlib Things related to the PhotonVision library label Jul 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

photonlib Things related to the PhotonVision library

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants