Merged
Conversation
Closed
Closed
mcm001
approved these changes
Sep 8, 2024
Contributor
mcm001
left a comment
mcm001
left a comment
There was a problem hiding this comment.
When I leave a review, I say "LGTM" because the code does "look good to me." Very demure, very mindful.
Contributor
|
Before merge, I want to take a read through here haha. Will get done Monday or Tuesday this week. |
mcm001
requested changes
Sep 8, 2024
mdurrani808
reviewed
Sep 10, 2024
Contributor
mdurrani808
left a comment
mdurrani808
left a comment
There was a problem hiding this comment.
appreciate all the hard work on this, much needed
photonlib-java-examples/aimandrange/src/main/java/frc/robot/Robot.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
#1418 needs to happen shortly after this is merged. |
…lllllllllllleeeeeeeeeeeeeeeesssssssssssssssssssssssssssssssssssssssssssssssssssss
Contributor
|
Updates address all my comments, ty! |
mcm001
approved these changes
Sep 14, 2024
mdurrani808
approved these changes
Sep 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals:
Minimize content to achieve those goals.