Refined network management#1672
Merged
crschardt merged 25 commits intoPhotonVision:mainfrom Jan 3, 2025
Merged
Conversation
This reverts commit 5b21e1d.
…hardt/photonvision into enable-link-local-with-dhcp
mcm001
reviewed
Jan 2, 2025
photon-core/src/main/java/org/photonvision/common/networking/NetworkUtils.java
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/util/ShellExec.java
Outdated
Show resolved
Hide resolved
Contributor
|
Will test on Chris' bench today |
mcm001
approved these changes
Jan 3, 2025
Contributor
mcm001
left a comment
mcm001
left a comment
There was a problem hiding this comment.
Passes smoke test for me anyway
crschardt
added a commit
to PhotonVision/photon-image-modifier
that referenced
this pull request
Jan 4, 2025
With PhotonVision/photonvision#1672, the network handling is more robust. It should be OK to not wait for NetworkManager to detect online during the boot process. This will speed bootup, especially first boot if the system isn't connected to a network.
mcm001
pushed a commit
to mcm001/photonvision
that referenced
this pull request
Feb 18, 2025
This PR implements several refinements to the way that NetworkManager controls the network interface. - The monitor detects and logs changes to the network address - The monitor detects and logs changes to the connection and will reinitialize the connection if needed - Remove NetworkInterface.java class, which wasn't used anywhere - Use java.net.NetworkInterface to get IP addresses for any interface (device) - Adds a metric for the current IP address (address on the currently selected interface)
Gold856
added
frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements several refinements to the way that NetworkManager controls the network interface.