Convert to user selected camera matching#1556
Merged
mcm001 merged 98 commits intoPhotonVision:mainfrom Jan 1, 2025
Merged
Conversation
mcm001
reviewed
Nov 11, 2024
photon-core/src/main/java/org/photonvision/vision/camera/CameraInfo.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Nov 11, 2024
photon-core/src/main/java/org/photonvision/vision/processes/VisionSourceManager.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Nov 11, 2024
photon-core/src/main/java/org/photonvision/vision/processes/VisionSourceManager.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Nov 11, 2024
photon-core/src/main/java/org/photonvision/vision/processes/VisionSourceManager.java
Outdated
Show resolved
Hide resolved
TODO: delete protection + camera stream size matching
Juniormunk
approved these changes
Jan 1, 2025
Contributor
Juniormunk
left a comment
Juniormunk
left a comment
There was a problem hiding this comment.
These are some of my notes/questions. We should take care of them at some point. We don't need to do it in this PR; we need this.
Why are there different CameraInfoClasses and not just a camera type value?
We need to add some sort of password block to the new camera delete button.
The camera UUID is displayed in the UI when the camera is deleted. The camera UUID stuff seems a little half-baked.
There may be some sort of memory leak when deactivating cameras.
It seems like we might need better handling of no video modes and a video mode full of null?
Contributor
|
Risk posture is to just fail forwards and fix things in main. All good notes though, thanks for capturing them! |
mcm001
pushed a commit
to mcm001/photonvision
that referenced
this pull request
Feb 18, 2025
6 tasks
Gold856
added a commit
to Gold856/photonvision
that referenced
this pull request
Mar 26, 2025
Gold856
added a commit
to Gold856/photonvision
that referenced
this pull request
Mar 30, 2025
Gold856
added a commit
to Gold856/photonvision
that referenced
this pull request
Mar 30, 2025
Gold856
added a commit
to Gold856/photonvision
that referenced
this pull request
Apr 3, 2025
Gold856
added a commit
to Gold856/photonvision
that referenced
this pull request
Apr 14, 2025
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.