Skip to content

[fix] Broadcast optimizer state using broadcast_dp without shard-resh…#8522

Merged
wawltor merged 1 commit into
PaddlePaddle:developfrom
bo-ke:develop
Jun 3, 2024
Merged

[fix] Broadcast optimizer state using broadcast_dp without shard-resh…#8522
wawltor merged 1 commit into
PaddlePaddle:developfrom
bo-ke:develop

Conversation

@bo-ke
Copy link
Copy Markdown
Contributor

@bo-ke bo-ke commented May 31, 2024

…ard.

PR types

PR changes

Description

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented May 31, 2024

Thanks for your contribution!

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 31, 2024

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 31, 2024

Codecov Report

❌ Patch coverage is 14.28571% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.96%. Comparing base (e71540b) to head (a8d5fc1).
⚠️ Report is 1144 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 0.00% 3 Missing ⚠️
paddlenlp/trainer/utils/helper.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8522      +/-   ##
===========================================
- Coverage    53.97%   53.96%   -0.01%     
===========================================
  Files          618      618              
  Lines        96825    96827       +2     
===========================================
- Hits         52260    52256       -4     
- Misses       44565    44571       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wawltor wawltor merged commit 440c093 into PaddlePaddle:develop Jun 3, 2024
Copy link
Copy Markdown
Contributor

@wawltor wawltor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bo-ke added a commit to bo-ke/PaddleNLP that referenced this pull request Jun 3, 2024
DesmonDay pushed a commit that referenced this pull request Jun 3, 2024
* [fea] moe support (#8498)

Co-authored-by: kebo01 <kebo01@baidu.com>

* [fix] Broadcast optimizer state using broadcast_dp without shard-reshard. (#8522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants