Skip to content

[fea] moe support#8498

Merged
wawltor merged 1 commit into
PaddlePaddle:developfrom
bo-ke:develop
May 31, 2024
Merged

[fea] moe support#8498
wawltor merged 1 commit into
PaddlePaddle:developfrom
bo-ke:develop

Conversation

@bo-ke
Copy link
Copy Markdown
Contributor

@bo-ke bo-ke commented May 27, 2024

PR types

PR changes

Description

@paddle-bot
Copy link
Copy Markdown

paddle-bot Bot commented May 27, 2024

Thanks for your contribution!

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 27, 2024

CLA assistant check
All committers have signed the CLA.

Comment thread paddlenlp/trainer/trainer.py Outdated
@bo-ke bo-ke force-pushed the develop branch 2 times, most recently from 0e4c89d to 55dd5a3 Compare May 28, 2024 04:37
Comment thread paddlenlp/trainer/trainer.py
@bo-ke bo-ke force-pushed the develop branch 2 times, most recently from 92dbe7c to 2851da8 Compare May 28, 2024 08:45
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2024

Codecov Report

❌ Patch coverage is 2.34375% with 125 lines in your changes missing coverage. Please review.
✅ Project coverage is 53.97%. Comparing base (0cd8fe7) to head (8894d32).
⚠️ Report is 1165 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/trainer/trainer.py 2.32% 42 Missing ⚠️
paddlenlp/trainer/utils/helper.py 2.43% 40 Missing ⚠️
paddlenlp/trainer/training_args.py 5.00% 19 Missing ⚠️
paddlenlp/trainer/utils/sharding_io.py 0.00% 13 Missing ⚠️
paddlenlp/trainer/utils/reshard/common.py 0.00% 11 Missing ⚠️

❌ Your patch status has failed because the patch coverage (2.34%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project status has failed because the head coverage (53.97%) is below the target coverage (58.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8498      +/-   ##
===========================================
- Coverage    54.27%   53.97%   -0.31%     
===========================================
  Files          617      618       +1     
  Lines        96356    96801     +445     
===========================================
- Hits         52302    52249      -53     
- Misses       44054    44552     +498     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread paddlenlp/trainer/utils/helper.py Outdated
@bo-ke bo-ke force-pushed the develop branch 5 times, most recently from 939c0d2 to 38dfa82 Compare May 29, 2024 12:11
Comment thread paddlenlp/trainer/trainer.py Outdated
Comment thread paddlenlp/trainer/training_args.py Outdated
Comment thread paddlenlp/trainer/utils/reshard/common.py Outdated
Comment thread paddlenlp/trainer/utils/helper.py
Comment thread paddlenlp/trainer/trainer.py Outdated
Comment thread paddlenlp/trainer/trainer.py Outdated
Comment thread paddlenlp/trainer/trainer.py Outdated
Comment thread paddlenlp/trainer/trainer.py Outdated
Comment thread paddlenlp/trainer/training_args.py Outdated
@bo-ke bo-ke force-pushed the develop branch 2 times, most recently from f0cde72 to 67981e5 Compare May 30, 2024 06:58
Comment thread paddlenlp/trainer/utils/helper.py
ZHUI
ZHUI previously approved these changes May 30, 2024
Copy link
Copy Markdown
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DesmonDay
Copy link
Copy Markdown
Contributor

有些代码看看能不能是不是参考我这个PR的修改:#8511

Comment thread paddlenlp/trainer/trainer.py Outdated
Comment thread paddlenlp/trainer/trainer.py
Comment thread paddlenlp/trainer/trainer.py Outdated
@bo-ke bo-ke force-pushed the develop branch 4 times, most recently from 28e8dcc to 813c705 Compare May 30, 2024 11:03
Comment thread paddlenlp/trainer/trainer.py Outdated
Comment thread paddlenlp/trainer/trainer.py Outdated
Comment thread paddlenlp/trainer/trainer.py
Copy link
Copy Markdown
Contributor

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wawltor wawltor merged commit ac7145d into PaddlePaddle:develop May 31, 2024
bo-ke added a commit to bo-ke/PaddleNLP that referenced this pull request Jun 3, 2024
DesmonDay pushed a commit that referenced this pull request Jun 3, 2024
* [fea] moe support (#8498)

Co-authored-by: kebo01 <[email protected]>

* [fix] Broadcast optimizer state using broadcast_dp without shard-reshard. (#8522)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants