Skip to content

[PIR] A-13 Adapt expand test_errors #62849

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
0x45f merged 8 commits into from
Mar 25, 2024
Merged

[PIR] A-13 Adapt expand test_errors #62849

0x45f merged 8 commits into from
Mar 25, 2024

Conversation

@ooooo-create
Copy link
Contributor

@ooooo-create ooooo-create commented Mar 19, 2024 •
edited
Loading

PR types

Others

PR changes

Others

Description

ref #60696
test/legacy_test/test_expand_v2_op.py
test/legacy_test/test_broadcast_to_op.py

@paddle-bot
Copy link

paddle-bot bot commented Mar 19, 2024

你的PR提交成功，感谢你对开源项目的贡献!
请关注后续CI自动化测试结果，详情请参考Paddle-CI手册。
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added the contributor External developers label Mar 19, 2024
@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Mar 19, 2024
@0x45f
Copy link
Contributor

0x45f commented Mar 20, 2024

这里要修改的单测文件应该是test/legacy_test/test_expand_v2_op.py，这个文件test/legacy_test/test_expand_op.py不用修改~

@ooooo-create
Copy link
Contributor Author

ooooo-create commented Mar 20, 2024

这里要修改的单测文件应该是test/legacy_test/test_expand_v2_op.py，这个文件test/legacy_test/test_expand_op.py不用修改~

好的，Thanks

@zrr1999 zrr1999 mentioned this pull request Mar 20, 2024
Closed
0x45f
0x45f reviewed Mar 21, 2024
View reviewed changes
0x45f
0x45f reviewed Mar 21, 2024
View reviewed changes
@0x45f
Copy link
Contributor

0x45f commented Mar 22, 2024

辛苦把test/legacy_test/test_broadcast_to_op.py 中的uint8的error 测试case也删掉吧~ broadcast_to里面调用的就是expand，可以一起把broadcast_to的test error也一起适配一下~

@ooooo-create
Copy link
Contributor Author

ooooo-create commented Mar 22, 2024

辛苦把test/legacy_test/test_broadcast_to_op.py 中的uint8的error 测试case也删掉吧~ broadcast_to里面调用的就是expand，可以一起把broadcast_to的test error也一起适配一下~

done~

sunzhongkai588
sunzhongkai588 approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@sunzhongkai588 sunzhongkai588 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

中文 broadcast_to 文档同步辛苦修改一下～

@0x45f
Copy link
Contributor

0x45f commented Mar 25, 2024

辛苦同步修改下docs仓库中expand和broadcast_to的中文文档~

@ooooo-create ooooo-create mentioned this pull request Mar 25, 2024
Merged
@ooooo-create
Copy link
Contributor Author

ooooo-create commented Mar 25, 2024

已提交中文文档的修改 PaddlePaddle/docs#6542

@0x45f 0x45f merged commit 6b3f90e into PaddlePaddle:develop Mar 25, 2024
@ooooo-create ooooo-create deleted the test_errors_a_13 branch March 25, 2024 06:56
This was referenced Mar 26, 2024
Closed
Merged
@Tongkaio Tongkaio mentioned this pull request Mar 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0x45f 0x45f 0x45f approved these changes

@sunzhongkai588 sunzhongkai588 sunzhongkai588 approved these changes

Assignees

@luotao1 luotao1

@0x45f 0x45f

@zrr1999 zrr1999

Labels

contributor External developers HappyOpenSource 快乐开源活动issue与PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ooooo-create @0x45f @sunzhongkai588 @luotao1 @zrr1999