Skip to content

Conversation

@xiaoguoguo626807
Copy link
Contributor

@xiaoguoguo626807 xiaoguoguo626807 commented Feb 28, 2024

PR types

others

PR changes

others

Description

pcard-67164

  1. add_n 的输入全部都是None时报错,修改append_add_n函数,当全部输入都是None时,直接返回,把state.value_to_valuegrad[value] 设置为[], 这样会进入下一个分支标记zero_flag = True. 此处zero_flag的语义扩展,表达梯度是full_like 0得到 或 其他op返回了none
  2. split_with_num 的结果命中builtin.split的梯度制作分支,但当在if block中原来的first_use 会被改为tuple_push,导致无法命中,修改为函数判断所有user 有builtin.split就返回builtin.split op, 否则返回None
  3. add_n 的build函数中调用addninfemeta没有加runtime信息,导致动态shape检查出错
  4. 嵌套删除op 边搜索边删除导致op访问有误,op.name() 得到的是字节值

@paddle-bot
Copy link

paddle-bot bot commented Feb 28, 2024

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@xiaoguoguo626807 xiaoguoguo626807 changed the title modify Paddle detection bug 【pir】modify Paddle detection bug Feb 28, 2024
changeyoung98
changeyoung98 previously approved these changes Feb 28, 2024
Copy link
Contributor

@changeyoung98 changeyoung98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiaoguoguo626807 xiaoguoguo626807 merged commit b0ae0c2 into PaddlePaddle:develop Feb 28, 2024
@xiaoguoguo626807 xiaoguoguo626807 deleted the paddle_detection2 branch June 4, 2025 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants