Skip to content

Conversation

@enkilee
Copy link
Contributor

@enkilee enkilee commented Sep 22, 2022

fix bugs

PR types

PR changes

Describe

@paddle-bot
Copy link

paddle-bot bot commented Sep 22, 2022

你的PR提交成功,感谢你对开源项目的贡献!
请关注后续CI自动化测试结果,详情请参考Paddle-CI手册
Your PR has been submitted. Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@paddle-bot paddle-bot bot added contributor External developers status: proposed labels Sep 22, 2022
@paddle-bot
Copy link

paddle-bot bot commented Sep 22, 2022

❌ The PR is not created using PR's template. You can refer to this Demo.
Please use PR's template, it helps save our maintainers' time so that more developers get helped.

Copy link
Member

@SigureMo SigureMo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

PR 描述没有按模板来,这个我就不帮你改啦~

If True, use the overwrite mode to update the output of the same index,
if False, use the accumulate mode to update the output of the same index.Default value is True.
overwrite (bool): The mode that updating the output when there are same indices. If True, use the overwrite mode to update the output of the same index, if False, use the accumulate mode to update the output of the same index.Default value is True.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里折一下行吧,其实把那个空行删掉应该就可以了

rst 会在多行之间自动加一个空格,就像这样:

xxxxxxxxxxxxxx
yyyyyyyyyyyyyy
zzzzzzzzzzzzzz

会渲染成

<p>xxxxxxxxxxxxxx yyyyyyyyyyyyyy zzzzzzzzzzzzzz</p>

这种效果在英文中是恰到好处的,而在中文却是有问题的,英文这边由于是写在 docstring 里的,是需要便于开发者在编辑器阅读的,因此行宽不能过长,这也是为什么英文建议折行,而中文不建议折行。

flake8 有一个错误码就是针对行宽的,不过目前没有启用,而且优先级也不高,但还是尽可能地不要让行宽太宽吧~

以及 2674 行因为有一个 tab,应该会与 #46288 冲突,所以可以等等再 merge

@Ligoml
Copy link
Contributor

Ligoml commented Oct 9, 2022

这个issue已经被 #46765 解决

@Ligoml Ligoml closed this Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants