Skip to content

Conversation

@SigureMo
Copy link
Member

@SigureMo SigureMo commented Sep 20, 2022

PR types

Others

PR changes

Others

Describe

修复 remove-tabs 存量 python 代码('\t' -> ' ' * 4

并修正部分格式问题

fluid 单测拆分到 PR #46357

NPU 单测又出问题了,因此拆分新的 PR(#46309


@SigureMo

This comment was marked as outdated.

@SigureMo SigureMo changed the title [CodeStyle] remove tabs in python files [CodeStyle][W191][E101] remove tabs in python files Sep 20, 2022
@SigureMo
Copy link
Member Author

image

又有很多示例代码报错了,不过这次都是 fluid 的

@paddle-bot-old paddle-bot-old bot added the contributor External developers label Sep 20, 2022
@SigureMo SigureMo closed this Sep 20, 2022
@SigureMo SigureMo reopened this Sep 20, 2022
@paddle-bot
Copy link

paddle-bot bot commented Sep 20, 2022

很抱歉,经过我们的反复讨论,你的PR暂未达到合入标准,请阅读飞桨原生算子开发规范,你可以重新提交新的PR,我们先将此PR关闭,感谢你的贡献。
Sorry to inform you that through our discussion, your PR fails to meet the merging standard (Reference: Paddle Custom Operator Design Doc). You can also submit an new one. Thank you.

@luotao1 luotao1 self-assigned this Sep 21, 2022
@luotao1
Copy link
Contributor

luotao1 commented Sep 21, 2022

又有很多示例代码报错了,不过这次都是 fluid 的

@Ligoml 讨论:python/paddle/fluid下的API将于2.5完成清理,因此可以不做格式化修改。但需要保留单测目录python/paddle/fluid/tests

luotao1
luotao1 previously approved these changes Sep 22, 2022
@luotao1 luotao1 requested a review from Ligoml September 22, 2022 10:51
Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改的都是注释,可以使用test=document_fix

@SigureMo SigureMo requested a review from Ligoml September 23, 2022 08:20
Copy link
Contributor

@Ligoml Ligoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for docs

@luotao1 luotao1 merged commit ed2bb05 into PaddlePaddle:develop Sep 23, 2022
@SigureMo SigureMo deleted the tabs/fix/py branch September 23, 2022 09:29
umiswing pushed a commit to umiswing/Paddle that referenced this pull request Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contributor External developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants