copy found_inf to cpu in advance to improve performance #34274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
zhiqiu
force-pushed
the
dev/copy_found_inf_to_cpu
branch
from
a7c2068 to
dd7bbc3
Compare
chenwhql
approved these changes
Jul 22, 2021
Contributor
chenwhql
left a comment
chenwhql
left a comment
There was a problem hiding this comment.
LGTM for PADDLE_ENFORCE
zhhsplendid
approved these changes
Jul 22, 2021
phlrain
approved these changes
Jul 22, 2021
Contributor
Author
Refined in #34330, thanks. |
zhaoyinglia
pushed a commit
to zhaoyinglia/Paddle
that referenced
this pull request
Sep 2, 2021
…#34274) * copy found_inf to cpu in advance to improve performance * add npu test * add npu test * refine code * refine memcpy op * fix adam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Performance optimization
PR changes
Others
Describe
Since found_inf needs to be on cpu in adam op, we copy it in advance to avoid multiple time copies.