Skip to content

Add zhhsplendid into PE Approver #27919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2020
Merged

Add zhhsplendid into PE Approver #27919

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71d1c1e
Add zhhsplendid into PE approver, test=develop
zhhsplendid Oct 14, 2020
9c58011
Fix /tab, space mix usage
zhhsplendid Oct 14, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions tools/check_file_diff_approvals.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ API_FILES=("CMakeLists.txt"
"paddle/fluid/framework/ir/node.h"
"paddle/fluid/framework/ir/graph.h"
"paddle/fluid/framework/framework.proto"
"python/paddle/distributed/__init"
"python/paddle/distributed/fleet/__init__.py"
"python/paddle/distributed/__init"
"python/paddle/distributed/fleet/__init__.py"
"python/requirements.txt"
"python/paddle/fluid/__init__.py"
"python/paddle/fluid/compiler.py"
Expand Down Expand Up @@ -143,9 +143,12 @@ for API_FILE in ${API_FILES[*]}; do
elif [ "${API_FILE}" == "paddle/scripts/paddle_build.bat" ]; then
echo_line="You must have one RD (zhouwei25 (Recommend), luotao1) approval for ${API_FILE} changes, which manages all Paddle CI task on Windows.\n"
check_approval 1 52485244 6836917
elif [ "${API_FILE}" == "python/paddle/fluid/parallel_executor.py" ]; then
echo_line="You must have one RD (Xreki,luotao1,zhhsplendid) approval for ${API_FILE}, which manages the underlying code for PaddlePaddle.\n"
check_approval 1 12538138 6836917 7913861
else
echo_line="You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for ${API_FILE}, which manages the underlying code for fluid.\n"
check_approval 1 3048612 46782768 12538138 6836917
check_approval 1 46782768 12538138 6836917
fi
fi
done
Expand All @@ -154,7 +157,7 @@ FILTER=`git diff --name-only upstream/develop | grep -v "tools/"`
HAS_CONST_CAST=`git diff -U0 upstream/$BRANCH $FILTER |grep -o -m 1 "const_cast" || true`
if [ ${HAS_CONST_CAST} ] && [ "${GIT_PR_ID}" != "" ]; then
echo_line="You must have one RD (XiaoguangHu01,Xreki,luotao1) approval for the usage (either add or delete) of const_cast.\n"
check_approval 1 3048612 46782768 12538138 6836917
check_approval 1 46782768 12538138 6836917
fi

HAS_BOOST_GET=`git diff -U0 upstream/$BRANCH $FILTER |grep "^+" |grep -o -m 1 "boost::get" || true`
Expand Down