Skip to content

Add zhhsplendid into PE Approver #27919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 20, 2020
Merged

Add zhhsplendid into PE Approver #27919

merged 2 commits into from
Oct 20, 2020

Conversation

@zhhsplendid
Copy link
Member

@zhhsplendid zhhsplendid commented Oct 14, 2020 •
edited
Loading

PR types

Others

PR changes

Others

Describe

  1. Add zhhsplendid into approver for Parallel Executor
  2. Delete a unknown approver id 3048612
  3. Fix a /tab space mixed usage at line 36-37 of check_file_diffwhich can show different line indents on my vim.

@paddle-bot-old
Copy link

paddle-bot-old bot commented Oct 14, 2020

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@zhhsplendid zhhsplendid changed the title Add zhhsplendid into PE approver, test=develop Add zhhsplendid into PE Approver Oct 14, 2020
@luotao1 luotao1 merged commit 0b733e4 into PaddlePaddle:develop Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luotao1 luotao1 luotao1 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhhsplendid @luotao1