fix Error of gpu version paddle when CUDA device is not set properly #27819
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
pangyoki
changed the title
zhiqiu
reviewed
Oct 10, 2020
python/paddle/fluid/framework.py
Outdated
| if device_count > 0: | ||
| _global_expected_place_ = core.CUDAPlace(0) | ||
| else: | ||
| logging.warning( |
Contributor
There was a problem hiding this comment.
Use warnings instead of logging
python/paddle/fluid/framework.py
Outdated
| _global_expected_place_ = core.CUDAPlace(0) | ||
| else: | ||
| logging.warning( | ||
| "You are using GPU version Paddle, But Your CUDA Device is not set properly. CPU device will be used by default." |
zhiqiu
approved these changes
Oct 13, 2020
| try: | ||
| device_count = core.get_cuda_device_count() | ||
| except Exception as e: | ||
| device_count = 0 |
Contributor
There was a problem hiding this comment.
I think we need to do something if an Exception happens instead of just ignore it, we can raise warnings at least. It can be refined in the next PR.
| stderr=subprocess.PIPE) | ||
| stdout, stderr = ps_proc.communicate() | ||
|
|
||
| assert 'CPU device will be used by default' in str( |
Contributor
There was a problem hiding this comment.
Not important.
Since unittest is used, I recommend using unittest's API, like self.assertXXX instead of python's builtin assert.
chen-zhiyu
pushed a commit
to chen-zhiyu/Paddle
that referenced
this pull request
Oct 15, 2020
…addlePaddle#27819) * fix gpu version paddle Error when have no CUDA device * optimize format and add new unittest * fix coverage problem * fix unittest format * change static mode to dygraph mode * use subprocess in unittest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
When users install GPU version Paddle, CPU device can't be used if CUDA device is not set properly.
To open dygraph mode by default.
disable static()is used inpaddle/__init__.py. Refer to PR Use dygraph mode by default #27443 .When Paddle is compiled with CUDA version,
CUDAPlace(0)will be used if default place isNone. It will raise Error if CUDA device is not set properly.This PR is used to solve this problem. CPU device will be used by default when there's no proper CUDA devices.