-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Use dygraph mode by default #27443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zhiqiu
merged 8 commits into
PaddlePaddle:develop
from
pangyoki:use-dygraph-mode-by-default
Sep 22, 2020
Merged
Use dygraph mode by default #27443
zhiqiu
merged 8 commits into
PaddlePaddle:develop
from
pangyoki:use-dygraph-mode-by-default
Sep 22, 2020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
3587099 to
19e0bb3
Compare
19e0bb3 to
579764d
Compare
zhiqiu
approved these changes
Sep 22, 2020
Contributor
zhiqiu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
XiaoguangHu01
approved these changes
Sep 22, 2020
Contributor
XiaoguangHu01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
raindrops2sea
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Breaking changes
PR changes
Others
Describe
Paddle 2.0 uses
dygraph modeby default. This PR change the default mode fromstatic modetodygraph mode.1. use dygraph mode by default
In
paddle/__init__.py, adddisable_static()to change the default mode todygraph mode.2. manually change unittest's mode to static mode
Unittest is realized based on static mode. It will cause conflicts when dygraph mode is opened by default.
In order to pass CI, before the unittest runs, switch the mode to static mode.
modify
test_runner.pyWhen using
ctestto execute unittest files,test_runner.pyis the entry point for many unittest files.test_runner.pywill call the module in unittest files to execute.Thus, we can add
enable_staticintest_runner.py. Before running unittest,test_runner.pywill provide static mode.modify unittest file
Some unittests are not executed based on
test_runner.py, so their running environment is still dygraph mode, and CI wil fail.To solve this problem, we modify all unittests in the CI error report manually.
The following files will be added
enable_staticmanually.CI-Mac
CI-Py3
CI-coverage