Skip to content

Conversation

@pangyoki
Copy link
Contributor

@pangyoki pangyoki commented Sep 21, 2020

PR types

Breaking changes

PR changes

Others

Describe

Paddle 2.0 uses dygraph mode by default. This PR change the default mode from static mode to dygraph mode.

1. use dygraph mode by default

In paddle/__init__.py, add disable_static() to change the default mode to dygraph mode.

2. manually change unittest's mode to static mode

Unittest is realized based on static mode. It will cause conflicts when dygraph mode is opened by default.
In order to pass CI, before the unittest runs, switch the mode to static mode.

  • modify test_runner.py
    When using ctest to execute unittest files, test_runner.py is the entry point for many unittest files. test_runner.py will call the module in unittest files to execute.
    Thus, we can add enable_static in test_runner.py. Before running unittest, test_runner.py will provide static mode.

  • modify unittest file
    Some unittests are not executed based on test_runner.py, so their running environment is still dygraph mode, and CI wil fail.
    To solve this problem, we modify all unittests in the CI error report manually.
    The following files will be added enable_static manually.

CI-Mac

2020-09-17 21:17:20 	132 - test_train_recognize_digits_mlp (Failed)
2020-09-17 21:17:20 	133 - test_train_recognize_digits_conv (Failed)
2020-09-17 21:17:20 	156 - test_beam_search_decoder (Failed)
2020-09-17 21:17:20 	157 - test_data_feeder (Failed)
2020-09-17 21:17:20 	158 - test_detection (Failed)
2020-09-17 21:17:20 	159 - test_error_clip (Failed) # add enable_static
2020-09-17 21:17:20 	160 - test_if_else_op (Failed)
2020-09-17 21:17:20 	162 - test_python_operator_overriding (Failed)
2020-09-17 21:17:20 	615 - test_nan_inf (Failed) # add enable_static
2020-09-17 21:17:20 	954 - test_fit_a_line (Failed)
2020-09-17 21:17:20 	955 - test_image_classification (Failed)
2020-09-17 21:17:20 	956 - test_label_semantic_roles (Failed)
2020-09-17 21:17:20 	957 - test_machine_translation (Failed)
2020-09-17 21:17:20 	958 - test_recognize_digits (Failed)
2020-09-17 21:17:20 	959 - test_recommender_system (Failed) # add enable_static
2020-09-17 21:17:20 	960 - test_rnn_encoder_decoder (Failed)
2020-09-17 21:17:20 	961 - test_word2vec (Failed)
2020-09-17 21:17:20 	964 - test_fp16_utils (Failed)
2020-09-17 21:17:20 	966 - test_quantize_transpiler (Failed)
2020-09-17 21:17:20 	967 - test_weight_decay_extend (Failed)
2020-09-17 21:17:20 	968 - test_graph (Failed)
2020-09-17 21:17:20 	969 - test_imperative_qat (Failed)
2020-09-17 21:17:20 	970 - test_post_training_quantization_mnist (Failed)
2020-09-17 21:17:20 	971 - test_post_training_quantization_mobilenetv1 (Failed)
2020-09-17 21:17:20 	972 - test_post_training_quantization_resnet50 (Failed)
2020-09-17 21:17:20 	973 - test_quant2_int8_mkldnn_pass (Failed)
2020-09-17 21:17:20 	974 - test_quantization_mkldnn_pass (Failed)
2020-09-17 21:17:20 	975 - test_quantization_pass (Failed)
2020-09-17 21:17:20 	976 - test_quantization_scale_pass (Failed)
2020-09-17 21:17:20 	977 - test_user_defined_quantization (Failed)
2020-09-17 21:17:20 	978 - test_weight_quantization_mobilenetv1 (Failed)
test_communicator_geo

CI-Py3

2020-09-20 21:01:30 	268 - test_allreduce (Timeout)
2020-09-20 21:01:30 	327 - test_collective_allgather_api (Failed)
2020-09-20 21:01:30 	330 - test_collective_barrier_api (Failed)
2020-09-20 21:01:30 	333 - test_collective_reduce (Timeout)
2020-09-20 21:01:30 	335 - test_collective_scatter (Timeout)
2020-09-20 21:01:30 	813 - test_reducescatter (Timeout)
2020-09-20 21:01:30 	952 - test_communicator_half_async (Timeout)
2020-09-20 21:01:30 	1031 - test_auto_checkpoint (Failed)
2020-09-20 21:01:30 	1033 - test_auto_checkpoint2 (Failed)
2020-09-20 21:01:30 	1035 - test_auto_checkpoint_multiple (Failed)
2020-09-20 21:01:30 	1134 - test_correlation (Failed)
2020-09-20 21:01:30 	267 - test_allgather (Timeout)
2020-09-20 21:01:30 	309 - test_broadcast (Timeout)
2020-09-20 21:01:30 	328 - test_collective_allreduce_api (Failed)
2020-09-20 21:01:30 	332 - test_collective_broadcast_api (Failed)
2020-09-20 21:01:30 	334 - test_collective_reduce_api (Failed)
2020-09-20 21:01:30 	336 - test_collective_scatter_api (Failed)
2020-09-20 21:01:30 	814 - test_reducescatter_api (Timeout)
2020-09-20 21:01:30 	974 - test_c_comm_init_op (Failed)
2020-09-20 21:01:30 	1032 - test_auto_checkpoint1 (Failed)
2020-09-20 21:01:30 	1034 - test_auto_checkpoint3 (Failed)
2020-09-20 21:01:30 	1036 - test_auto_checkpoint_dist_basic (Failed)
2020-09-20 21:01:30 	978 - test_dist_allreduce_op (Failed)
2020-09-20 21:01:30 	979 - test_dist_fleet_a_sync_optimizer_async (Failed)
2020-09-20 21:01:30 	980 - test_dist_fleet_a_sync_optimizer_auto (Failed)
2020-09-20 21:01:30 	981 - test_dist_fleet_a_sync_optimizer_auto_async (Failed)
2020-09-20 21:01:30 	982 - test_dist_fleet_a_sync_optimizer_auto_geo (Failed)
2020-09-20 21:01:30 	983 - test_dist_fleet_a_sync_optimizer_geo (Failed)
2020-09-20 21:01:30 	984 - test_dist_fleet_a_sync_optimizer_sync (Failed)
2020-09-20 21:01:30 	985 - test_dist_fleet_ctr (Failed)
2020-09-20 21:01:30 	986 - test_dist_fleet_geo (Failed)
2020-09-20 21:01:30 	989 - test_dist_fleet_heter_ctr (Failed)
2020-09-20 21:01:30 	990 - test_dist_fleet_heter_program (Failed)
2020-09-20 21:01:30 	996 - test_dist_fleet_simnet (Failed)
2020-09-20 21:01:30 	997 - test_dist_mnist_backward_deps (Failed)
2020-09-20 21:01:30 	998 - test_dist_mnist_batch_merge (Failed)
2020-09-20 21:01:30 	999 - test_dist_mnist_dgc_nccl (Failed)
2020-09-20 21:01:30 	1000 - test_dist_mnist_fleet_save (Failed)
2020-09-20 21:01:30 	1001 - test_dist_mnist_fleetapi (Failed)
2020-09-20 21:01:30 	1002 - test_dist_mnist_hallreduce (Failed)
2020-09-20 21:01:30 	1003 - test_dist_mnist_multi_comm (Failed)
2020-09-20 21:01:30 	1004 - test_dist_mnist_pg (Failed)
2020-09-20 21:01:30 	1005 - test_dist_mnist_ring_allreduce (Failed)
2020-09-20 21:01:30 	1006 - test_dist_mnist_with_program (Failed)
2020-09-20 21:01:30 	1009 - test_dist_se_resnext_nccl (Failed)
test_buffer_shared_memory_reuse_pass

CI-coverage

2020-09-22 07:44:41 The following tests FAILED: 
2020-09-22 07:44:41 	385 - test_collective_reduce (Timeout)
2020-09-22 07:44:41 	1231 - test_image_classification_fp16 (Failed)
2020-09-22 07:44:41 	1235 - test_quant_int8_googlenet_mkldnn (Failed)   # quant_int8_image_classification_comparison.py
2020-09-22 07:44:41 	1237 - test_quant_int8_mobilenetv2_mkldnn (Failed)  # quant_int8_image_classification_comparison.py
2020-09-22 07:44:41 	1239 - test_quant2_int8_resnet50_range_mkldnn (Failed)  # quant2_int8_image_classification_comparison.py
2020-09-22 07:44:41 	1241 - test_quant2_int8_mobilenetv1_mkldnn (Failed)  # quant2_int8_image_classification_comparison.py
2020-09-22 07:44:41 	1243 - save_quant2_model_resnet50 (Failed)  # save_quant_model.py
2020-09-22 07:44:41 	1245 - convert_model2dot_ernie (Failed)  # convert_model2dot.py
2020-09-22 07:44:41 	259 - test_text (Failed)
2020-09-22 07:44:41 	1226 - test_custom_op (Failed)
2020-09-22 07:44:41 	1234 - test_quant_int8_resnet50_mkldnn (Failed)  # quant_int8_image_classification_comparison.py
2020-09-22 07:44:41 	1236 - test_quant_int8_mobilenetv1_mkldnn (Failed)  # quant_int8_image_classification_comparison.py
2020-09-22 07:44:41 	1238 - test_quant2_int8_resnet50_mkldnn (Failed)  # quant2_int8_image_classification_comparison.py
2020-09-22 07:44:41 	1240 - test_quant2_int8_resnet50_channelwise_mkldnn (Failed)  # quant2_int8_image_classification_comparison.py
2020-09-22 07:44:41 	1242 - test_quant2_int8_ernie_mkldnn (Failed)  # quant2_int8_nlp_comparison.py
2020-09-22 07:44:41 	1244 - save_quant2_model_ernie (Failed)  # save_quant_model.py
2020-09-22 07:44:41 	1046 - test_dist_fleet_ps (Failed)
2020-09-22 07:44:41 	1047 - test_dist_fleet_ps2 (Failed)
2020-09-22 07:44:41 	1048 - test_dist_fleet_ps3 (Failed)
2020-09-22 07:44:41 	1049 - test_dist_fleet_ps4 (Failed)
2020-09-22 07:44:41 	1050 - test_dist_fleet_ps5 (Failed)
2020-09-22 07:44:41 	1062 - test_dist_op (Failed)
2020-09-22 07:44:41 	1066 - test_dist_transpiler_async_decay (Failed)
2020-09-22 07:44:41 	1067 - test_dist_transpiler_config (Failed)
2020-09-22 07:44:41 	1072 - test_listen_and_serv_op (Failed)
2020-09-22 07:44:41 	1073 - test_fleet_graph_execution_meta_optimizer (Failed)

@paddle-bot-old
Copy link

Thanks for your contribution!
Please wait for the result of CI firstly. See Paddle CI Manual for details.

@pangyoki pangyoki force-pushed the use-dygraph-mode-by-default branch from 3587099 to 19e0bb3 Compare September 22, 2020 02:37
@pangyoki pangyoki force-pushed the use-dygraph-mode-by-default branch from 19e0bb3 to 579764d Compare September 22, 2020 05:44
Copy link
Contributor

@zhiqiu zhiqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@XiaoguangHu01 XiaoguangHu01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants