Hide globals & redesign tls#23066
Closed
pawelpiotrowicz wants to merge 0 commit intoPaddlePaddle:developfrom
Closed
Hide globals & redesign tls#23066pawelpiotrowicz wants to merge 0 commit intoPaddlePaddle:developfrom
pawelpiotrowicz wants to merge 0 commit intoPaddlePaddle:developfrom
Conversation
Contributor
|
@pawelpiotrowicz To have tests started , you need to put in your commit message "test=develop" string next to other info |
pawelpiotrowicz
force-pushed
the
develop
branch
from
d6294cf to
a7bb1a8
Compare
Contributor
|
@pawelpiotrowicz Maybe you need to install pre-commit because integration CI failed. https://pre-commit.com/ |
pawelpiotrowicz
force-pushed
the
develop
branch
from
a7bb1a8 to
491c76d
Compare
Contributor
|
Paddle _ PR_CI_Coverage _ #53760 (19 Mar 20 10_22) _ Diff Coverage — TeamCity.pdf
|
Contributor
|
@luotao1 Hi, will you add a UT for this PR |
Contributor
|
Yes, I will add a UT, but I need some time. |
pawelpiotrowicz
force-pushed
the
develop
branch
from
c890b52 to
552e209
Compare
pawelpiotrowicz
force-pushed
the
develop
branch
from
552e209 to
3e2bc87
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jczaja