Skip to content

Enable ngraph through build_strategy#19266

Merged
luotao1 merged 7 commits intoPaddlePaddle:developfrom
baojun-nervana:ng_pass
Sep 4, 2019
Merged

Enable ngraph through build_strategy#19266
luotao1 merged 7 commits intoPaddlePaddle:developfrom
baojun-nervana:ng_pass

Conversation

@baojun-nervana
Copy link
Contributor

@baojun-nervana baojun-nervana commented Aug 16, 2019

This PR is enable ngraph pass for parallel executor through build strategy.

  • ngraph_subgraph_pass will be enabled through build strategy when FLAGS_use_ngraph=true
  • ngraph_subgraph_pass is updated to handle training. The pass uses subgraph_detector.cc. The subgraph_detector.cc was developed for inference and need a workaround for training.

This PR has a dependency on PR #19155
CC: @LeoZhao-Intel @pawelpiotrowicz

mozga-intel
mozga-intel previously approved these changes Aug 29, 2019
Copy link
Contributor

@mozga-intel mozga-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeoZhao-Intel
Copy link
Contributor

LGTM

@luotao1 luotao1 requested a review from tensor-tang September 4, 2019 06:29

framework::ir::GraphSafeRemoveNodes(graph, nodes2remove);
std::vector<ir::Node *> nodes = ir::TopologySortOperations(*graph);
// std::vector<ir::Node *> nodes = ir::TopologySortOperations(*graph);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or you can remove in next PR

Copy link
Contributor

@tensor-tang tensor-tang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luotao1 luotao1 merged commit a3a4b6e into PaddlePaddle:develop Sep 4, 2019
@baojun-nervana baojun-nervana deleted the ng_pass branch September 5, 2019 17:41
seiriosPlus pushed a commit to seiriosPlus/Paddle that referenced this pull request Dec 9, 2019
* enable ngraph throught build_strategy test=develop

* add unittest test=develop

* put use_ngraph unconditional test=develop

* remove paddle_enforce test=develop

* remove paddle_enforce test=develop

* fix copyright test=develop

* limit for ngraph only test=develop
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants