Skip to content

Update ngraph engine for multiple threading#19155

Merged
luotao1 merged 2 commits intoPaddlePaddle:developfrom
baojun-nervana:ng_update
Aug 28, 2019
Merged

Update ngraph engine for multiple threading#19155
luotao1 merged 2 commits intoPaddlePaddle:developfrom
baojun-nervana:ng_update

Conversation

@baojun-nervana
Copy link
Contributor

@baojun-nervana baojun-nervana commented Aug 12, 2019

This is update ngraph to handle multiple threading safe; prepare to enable parallel executor

  • Removed a few static class members which can cause issues for parallelization
  • changed backed_ to be per instance
    • used a weak pointer to hold the backend to keep it alive in desired lifetime; otherwise it may run into a case it will be destroyed too early
    • a mutex lock was used to keep it thread safe - this is subject to optimization which we are looking at.

CC. @pawelpiotrowicz @LeoZhao-Intel

Copy link
Contributor

@pawelpiotrowicz pawelpiotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@luotao1 luotao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for paddle_enforce

@luotao1 luotao1 merged commit 6421c61 into PaddlePaddle:develop Aug 28, 2019
@baojun-nervana baojun-nervana deleted the ng_update branch August 28, 2019 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants