Skip to content

fix con2d transpose bias by create and init it in build_once #18968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JiabinYang merged 11 commits into from
Aug 28, 2019
Merged

fix con2d transpose bias by create and init it in build_once #18968

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
866ca2e
fix con2d transpose bias by create and init it in build_onee
JiabinYang Aug 1, 2019
8897328
fix API spec
JiabinYang Aug 1, 2019
de85dcb
test=develop, invoke ci
JiabinYang Aug 1, 2019
5a7c200
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
JiabinYang Aug 14, 2019
534f801
fix bias_attr and act has no effect error on layer norm, conv2dTranpo…
JiabinYang Aug 15, 2019
d94d4a9
test=develop, change success standard for conv2dTranspose
JiabinYang Aug 20, 2019
b6d4251
test=develop, fix test_layers to invoke some error branch
JiabinYang Aug 22, 2019
b0a352d
test=develop, fix sample code
JiabinYang Aug 26, 2019
ffee117
test=develop, fix BilinearTensorProduct failed in dygraph mode
JiabinYang Aug 26, 2019
04c6c26
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle into…
JiabinYang Aug 27, 2019
fa7270c
test=develop, fix test_layers segment fault error
JiabinYang Aug 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 38 additions & 2 deletions python/paddle/fluid/dygraph/nn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2162,6 +2162,12 @@ def _build_once(self, input):
self._img_filter = self.create_parameter(
dtype=input.dtype, shape=filter_shape, attr=self._param_attr)

self._bias_param = self.create_parameter(
attr=self._bias_attr,
shape=[self._num_filters],
dtype=self._dtype,
is_bias=True)

def forward(self, input):
pre_bias = self._helper.create_variable_for_type_inference(
dtype=input.dtype)
Expand All @@ -2179,7 +2185,18 @@ def forward(self, input):
'use_cudnn': self._use_cudnn
})

pre_act = self._helper.append_bias_op(pre_bias, dim_start=1, dim_end=2)
if self._bias_param is not None:
pre_act = self._helper.create_variable_for_type_inference(
dtype=self._dtype)
self._helper.append_op(
type='elementwise_add',
inputs={'X': [pre_bias],
'Y': [self._bias_param]},
outputs={'Out': [pre_act]},
attrs={'axis': 1})
else:
pre_act = pre_bias

out = self._helper.append_activation(pre_act)
return out

Expand Down Expand Up @@ -2237,6 +2254,12 @@ def _build_once(self, input):
self._filter_param = self.create_parameter(
attr=self._param_attr, shape=filter_shape, dtype=self._dtype)

self._bias_param = self.create_parameter(
attr=self._bias_attr,
shape=[self._num_filters],
dtype=self._dtype,
is_bias=True)

def forward(self, input):
pre_bias = self._helper.create_variable_for_type_inference(self._dtype)
self._helper.append_op(
Expand All @@ -2251,7 +2274,19 @@ def forward(self, input):
'contextStart': -int(self._filter_size // 2),
'contextLength': self._filter_size
})
pre_act = self._helper.append_bias_op(pre_bias)

if self._bias_param is not None:
pre_act = self._helper.create_variable_for_type_inference(
dtype=self._dtype)
self._helper.append_op(
type='elementwise_add',
inputs={'X': [pre_bias],
'Y': [self._bias_param]},
outputs={'Out': [pre_act]},
attrs={'axis': 1})
else:
pre_act = pre_bias

return self._helper.append_activation(pre_act)


Expand Down Expand Up @@ -2614,6 +2649,7 @@ def forward(self, nodes_vector, edge_set):
out = self.create_variable(
name=self._name, dtype=self._dtype, persistable=False)
else:

out = self._helper.create_variable_for_type_inference(
dtype=self._dtype)

Expand Down